Ticket #3451 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SANS: Update Qxy to use the same underlying equations that Q1D uses

Reported by: Steve Williams Owned by: Anders Markvardsen
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

Currently Qxy() uses the old method of calculating I(Q) documented at the bottom of the Q1D page under versio 1. Update it to use the new formula documented on the Q1d wiki.

Change History

comment:1 Changed 9 years ago by Mathieu Doucet

Note that ORNL uses the current version of Qxy, so please make sure to keep the current version.

comment:2 Changed 9 years ago by Anders Markvardsen

In [14444]:

Some updates to doc for Q1D2. re #3451

comment:3 Changed 9 years ago by Russell Taylor

In [14447]:

Fix build. Method definition removed by mistake? Re #3451.

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:5 Changed 9 years ago by Anders Markvardsen

In [15003]:

Some initial steps towards allowing Qxy to include the same corrections as Q1D2. re #3451

comment:6 Changed 9 years ago by Anders Markvardsen

In [15023]:

Move more common code for sans Q1D and Qxy reduction into Qhelper.
Code for Qxy optional arguments added:

1) individual pixel corrections
2) individual bin (wavelength dep) correction
3) radius and wavelength cut

re #3451

comment:7 Changed 9 years ago by Anders Markvardsen

In [15040]:

Fix

re #3451

comment:8 Changed 9 years ago by Anders Markvardsen

In [15042]:

Make new Qxy active in python.....

re #3451

comment:9 Changed 9 years ago by Anders Markvardsen

In [15052]:

Updated ISIS sans 2D systemtests to reflect changes to Qxy.

re #3451

comment:10 Changed 9 years ago by Anders Markvardsen

comment:11 Changed 9 years ago by Martyn Gigg

In [15122]:

Minor increase in tolerance for error values that differ on platforms. Refs #3451

comment:12 Changed 9 years ago by Martyn Gigg

In [15125]:

Minor fix to Qxy to avoid an index out-of-bounds error from a loop that counts backward. (Might fix the tests on Linux?) Refs #3451

comment:13 Changed 9 years ago by Martyn Gigg

In [15133]:

Refs #3451

comment:14 Changed 9 years ago by Anders Markvardsen

  • Summary changed from Update Qxy to use the same underlying equations that Q1D uses to SANS: Update Qxy to use the same underlying equations that Q1D uses

comment:15 Changed 9 years ago by Anders Markvardsen

  • Status changed from new to accepted

comment:16 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 9 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:18 Changed 9 years ago by Karl Palmen

  • Status changed from verifying to closed

Unit tests exist for Q1D2, Q1D and Qxy and are passed (on Jenkins). I see that Q1D and Qxy use the same formula as show in the wiki as described although by different code.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4298

Note: See TracTickets for help on using tickets.