Make SAVEASCII work with Ragged Workspace

[Wenduo Zhou]

For a Workspace with multiple spectral, SaveASCII will only record the X-axis values of the first spectral (dataX(0)) to the saved file. Therefore, in the case of spectrum with different range or steps on x-axis, the algorithm breaks.

[Nick Draper]

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

[Nick Draper]

Moved to iteration 33 at iteration 32 code freeze

[Nick Draper]

Moved at end of release 2.1

[Nick Draper]

Moved at the end of release 2.2

[Nick Draper]

Moved to milestone 2.4

[Karl Palmen]

This is a documented feature of the algorithm.

See http://www.mantidproject.org/SaveAscii#Limitations

Removing this limitation would be an enhancement.

[Karl Palmen]

This could be done by having an X column for each spectrum.

The difficult part would be getting loadAscii to read it. Presently LoadAscii recognises three formats:

(1) Single spectrum without errors
(2) Any number of spectra with errors in Y
(3) Single spectrum with errors in both X and Y (not documented in wiki)

LoadAscii determines which one of the three it is merely by counting the columns. If there are two columns it's (1), if there are an odd number of columns at least 3, then it's (2) and if there are four columns, then it's (3).

Adding the above ragged format would render the above method unusable, because for example, seven columns could be either three spectra of (2) or two spectra in a ragged workspace. It would be necessary to read the column header or get the user to indicate the format.

[Karl Palmen]

If one always includes errors in X in a ragged workspace, the resulting ASCII file would have a number of columns divisible by four and hence LoadAscii could continue to determine the format type by number of columns. Note that case (2) about is the same as this for a single spectrum.

[Karl Palmen]

I've found that SaveAscii will save a multi-spectrum workspace with X-errors, but LoadAscii won't load it. For this option, I'm tempted to put the X values in for every spectrum as if the workspace were raggy.

[Karl Palmen]

Another issue. LoadAscii puts a common binning on all spectra. Should this be the case for a ragged workspace?

[Nick Draper]

Moved to backlog at the code freeze for R2.6

[Karl Palmen]

This ticket only applies to mult-spectra ASCII files. The current format for multi-spectra files is not considered to be good and will be revised in ticket #7732. Then it may be easier to support ragged workspaces. It does not makes sense to support ragged workspaces while the multi-spectra format is not good, hence this ticket is blocked by #7732.

[Nick Draper]

Bulk move to assigned at the introduction of the triage step

[Anders Markvardsen]

To reproduce do e.g.:

1. Load Test/GEM38370_Focussed_Legacy.nxs which is a ragged workspace

2. Run SaveAscii saving e.g. spectra with workspace indices 0-1

3. Inspect the save file and as reported have the same x-values

[Lottie Greenwood]

Commit 01 Refs #3493

Changeset: 7f171bd4592323c18284dd97b0e04d90edf91acf

[Lottie Greenwood]

Commit 02 Refs #3493

Changeset: 562065276bbbb5976a352016e80f821c296e83ab

[Lottie Greenwood]

Commit 03 Refs #3493

Changeset: fb7955bd03561d58416d1faba2ee66c232082fbf

[Lottie Greenwood]

Commit 04 Refs #3493

Changeset: 0d4a3e81cb17bdf0a3e12af66f70ed272fdf9c32

[Lottie Greenwood]

Commit 05 Refs #3493 fixed minor error

Changeset: 9e77959841486b1e727915c712293632cd4d4309

[Lottie Greenwood]

Commit 06 Refs #3493 edited to work w builds

Changeset: e6a77648a60f38498a0b423f2696a9932b4afaa7

[Lottie Greenwood]

Commit 06 Refs #3493 fixed difference in SF num

Changeset: 9a0f24769024c9cc1e3614f519d2d96db6b37616

[Lottie Greenwood]

Commit 07 Refs #3493 fixed typo

Changeset: 0c5432e892dcd519f8425f5cec484cdb2428597c

[Lottie Greenwood]

To test do

• Load Test/GEM38370_Focussed_Legacy.nxs which is a ragged workspace

• Run SaveAscii saving e.g. spectra with workspace indices 0-1

• Inspect the save file and check that each spectra has different X values

[Raquel Alvarez Banos]

Got a merge conflict:

$ git test start 3493 git fetch -p From github.com:mantidproject/mantid

x [deleted] (none) -> origin/feature/8091_control_spawning_of_plot_windows

remote: Counting objects: 42, done. remote: Compressing objects: 100% (42/42), done. Uremote: Total 42 (delta 18), reused 0 (delta 0) Unpacking objects: 100% (42/42), done.

965778d..4b0e772 master -> origin/master b8438d4..6657eff develop -> origin/develop 4af1040..5b53a77 feature/10441_refactor_spectrum_viewer -> origin/feature/10441_refactor_spectrum_viewer

git rebase --preserve-merges origin/master Successfully rebased and updated refs/heads/master. git merge --no-ff origin/bugfix/3493_SAVEASCII_work_with_ragged Auto-merging Test/AutoTestData/UsageData/GEM_Definition.vtp CONFLICT (add/add): Merge conflict in Test/AutoTestData/UsageData/GEM_Definition.vtp Automatic merge failed; fix conflicts and then commit the result.

WARNING: There were conflicts during the merge. If they are trivial please fix them, resolve the merge with 'git add' & 'git commit' and rerun this command. If you are unsure fail the ticket, run 'git merge --abort' and talk to the develop about solving the issues.

[Lottie Greenwood]

Commit 07 Refs #3493 removed vtp file

Changeset: 70674bebb81ca01b770e36ce3db850bf6465bc83

[Lottie Greenwood]

Merge branch 'master' into bugfix/3493_SAVEASCII_work_with_ragged

Full changeset: ​5dbb7032f8e0d2558bbc3c6e4926ebfc160bc731

[Raquel Alvarez Banos]

Merge remote-tracking branch 'origin/bugfix/3493_SAVEASCII_work_with_ragged'

Full changeset: ​84e8220da0f1fab2841bf185b228f373ba1d9f76

[Stuart Campbell]

This ticket has been transferred to github issue ​4340