Ticket #3495 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SavePHX algorithm needs a proper test

Reported by: Russell Taylor Owned by: Alex Buts
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

From the file SavePHXTest.h: 

// TODO: Add proper testing...

At the moment, it only tests that initialise() succeeds; it doesn't execute the algorithm.

Also, it's occasionally failing on the ORNL Mac buildserver for some reason (it segfaults after completion of the tests).

Change History

comment:1 Changed 9 years ago by Russell Taylor

In [13733]:

Re-jig SavePHXTest to see if it ends mystery test failures on ORNL mac build. Re #3495.

comment:2 Changed 9 years ago by Stuart Campbell

  • Owner changed from Stuart Campbell to Alex Buts
  • Status changed from new to assigned

comment:3 Changed 9 years ago by Alex Buts

  • Status changed from assigned to accepted

comment:4 Changed 9 years ago by Alex Buts

In [14036]:

refs #3495 test for phx creates file and tests if its contents is equal to the expected one.
Contents is actually produced by FindDetectorsPar algorithm

comment:5 Changed 9 years ago by Alex Buts

In [14037]:

refs #3495 fixing Unix errors .

comment:6 Changed 9 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:8 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

It looks like the test actually does check values and file writing.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4342

Note: See TracTickets for help on using tickets.