Separate Loading from Rebinning

[Owen Arnold]

At the moment, most plugins require that MDEW workspaces are binned to IMDWorkspaces before they can be visualized. This means users do not get the chance to see regions of interest in their data prior to rebinning. Secondly, this is all done as part of a single reading filter, so leads to significant delay to the user. A third effect is that PV doesn't provide good support for combined readers/filters leading to a few quirks in the framework, such as the inability to show interactors without first deselecting and reselecting the source.

#3444, as a proof of concept, demonstrates that we can separate the loading/image display from the rebinning. This is not a full solution but has provided some critical tools we need such as vtkMDEWHexahedronFactory.

#3276 was a start at rolling out the successful MVP pattern (currently used for MDWorkspace rebinning) to the combined loading rebinnning event-based plugins. This will now be redudant since we can have a single rebinning filter and separate loading presenters each creating and showing MDEWs, but putting the results into the ADS.

The new design is attached.

The implementation of this ticket should provide major improvements in the useability, speed and quality of VATES for the next release.

[Owen Arnold]

Also, Implementing this will allow us to drop the temp format *.ro_nxs which is used to distinguish between the experimental plugin and the original histogram-based plugin for the same type of MDEW nexus file.

[Owen Arnold]

In [13754]:

Refs #3276 #3507 Get rid of support for combined Rebinning/loading MVP.

[Owen Arnold]

In [13805]:

Refs #3507. Presenter for loading with implementation for OneStepMDEW. No concrete view yet set-up.

[Owen Arnold]

In [13806]:

Refs #3507. Fix GCC warnings

[Owen Arnold]

In [13807]:

Refs #3507. Update docs.

[Owen Arnold]

In [13879]:

Refs #3507. Presenter for Rebinning any type of MDEW.

[Owen Arnold]

In [13880]:

Refs #3507. Missing test file.

[Owen Arnold]

In [13883]:

Refs #3507. Disable test temporarily.

[Owen Arnold]

In [13916]:

Refs #3507. Kill warnings.

[Owen Arnold]

In [14005]:

Refs #3507. Need to be able to quickly loadup MDEW in order to look at metadata, without worrying about events. Extra flag added to loading algorithms.

[Owen Arnold]

In [14038]:

Refs #3507. Small modifications to behaviour of ImplicitFunctions.

[Owen Arnold]

In [14040]:

Refs #3507. Small change to setWorkspace method on ThresholdRange.

[Owen Arnold]

In [14041]:

Refs #3507. Correction to function/constructor declarations.

[Owen Arnold]

In [14048]:

Refs #3507. Full-move to MVP. Sorry for large checkin, but these things are all dependent and cannot have partially working GUI code.

[Owen Arnold]

In [14049]:

Refs #3507. Fix incomplete type.

[Owen Arnold]

In [14052]:

Refs #3507. Working through GCC errors.

[Owen Arnold]

In [14054]:

Refs #3507. Working through GCC errors.

[Owen Arnold]

In [14056]:

Refs #3507. Working through GCC errors.

[Owen Arnold]

In [14058]:

Refs #3507. Working through GCC errors.

[Owen Arnold]

In [14060]:

Refs #3507. Working through GCC errors. Getting down to last few.

[Owen Arnold]

In [14061]:

Refs #3507. Working through GCC warnings.

[Owen Arnold]

In [14062]:

Refs #3507. Remove redundant types. Will be able to do much more of this if MDWorkspaces are not supported in future.

[Owen Arnold]

In [14063]:

Refs #3507. Remove redundant types. Forgot to edit CMakeLists.txt.

[Owen Arnold]

In [14064]:

refs #3581 #3507. Scatter Plot now a separate plugin filter called "MDEW Scatter Plot" should show up under the alphabetic filter menu.

[Owen Arnold]

In [14066]:

refs #3581 #3507. Correct warnings and remove old reader.

[Owen Arnold]

In [14091]:

Refs #3507. Boost the test coverage. Particularly for common methods in base loading presenter.

[Owen Arnold]

In [14092]:

Refs #3507. Boost the test coverage. Test MVP for loading MDEW nexus types.

[Owen Arnold]

In [14099]:

Refs #3507. Fix type mismatch warning.

[Janik Zikovsky]

Loading a .NXS file is the first step, then you can display it via filters (which you can chain), as the ticket describes.

[Stuart Campbell]

This ticket has been transferred to github issue ​4354