Ticket #3519 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SaveISAWPeaks: crash from PeaksWorkspace from MDEWFindPeaks

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description


Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

In [13773]:

Refs #3519: SaveIsawPeaks will error out instead of crashing if no instrument.

comment:3 Changed 9 years ago by Janik Zikovsky

[13777] also.

comment:4 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Russell Taylor

Note that there's an ​InstrumentValidator available for this kind of thing.

comment:6 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:7 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The pointer check is right. As is Russell in using the extra validator to make sure you get the instrument without having to actually check.

Add the validator and the ticket can be closed.

comment:8 Changed 9 years ago by Russell Taylor

For info, the pointer method actually won't work as getInstrument creates a temporary parameterized instrument on each call.

comment:9 Changed 9 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:10 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

In [14835]:

Fixes #3519: Added InstrumentValidator for the workspace. The validator is a little chatty (prints a warning each time) but it works. Anyway, FindPeaksMD now saves the right instrument in the PeaksWorkspace so the original problem won't happen in normal use.

comment:11 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying

comment:12 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to closed

IT'S ALL GOOD!

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4366

Note: See TracTickets for help on using tickets.