Ticket #3521 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

FindPeaksMD: find the detector for a found peak

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

So that the PeaksWorkspace has the bank, row, col to save to ISAW.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

In [13775]:

Refs #3521: Utility function in instrument ray tracer.

comment:3 Changed 9 years ago by Janik Zikovsky

In [13777]:

Refs #3521: MDEWFindPeaks fills in the detector, row, col of the peaks found where possible. SaveIsawPeaks works with the output.

comment:4 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

In [13782]:

Fixes #3521: MDEWFindPeaks finds the detector and row and column.

comment:5 Changed 9 years ago by Janik Zikovsky

  • Summary changed from MDEWFindPeaks: find the detector for a found peak to FindPeaksMD: find the detector for a found peak

comment:6 Changed 9 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:7 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to reopened
  • Resolution fixed deleted

It is impossible to add an instrument to an MDworkspace (as it doesn't show up in the list of workspaces when you run LoadInstrument), so the FindPeaksMD just returns an error.

This is more likely a problem with the Workspace validator that only shows 'valid' workspaces.

comment:8 Changed 9 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:9 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Keep in mind that FindPeaksMD works off of MDEventWorkspaces, and not Alex's MDworkspaces. See for example this script:

# Basic parameters
filename = "TOPAZ_3131_event.nxs"
#Name of the workspaces to create
ws = "TOPAZ_3131"

# Load the original data
LoadEventNexus(Filename=filename,OutputWorkspace=ws)

# Convert to reciprocal space, in the sample frame
ConvertToDiffractionMDWorkspace(InputWorkspace=ws,OutputWorkspace=ws+'_MD',
		OutputDimensions='Q (sample frame)',LorentzCorrection='1')
		
# Find peaks
FindPeaksMD(InputWorkspace=ws+'_MD',MaxPeaks='50',OutputWorkspace=ws+'_peaks')

Also note that the instrument MUST have RectangularDetectors in order to find a meaningful row/column.

comment:10 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester changed from Peter Parker to Stuart Campbell

comment:11 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to closed

I do get some peaks...

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4368

Note: See TracTickets for help on using tickets.