Ticket #3541 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Make loading of files case insentive by default and user modifyable

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: critical Milestone: Release 2.0
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

Make loading of direct beam file case insentive.

Also, when using the Add Runs tab files with "-add" appended to the name are created. Make sure the reading of these is case insentive.

Richard writes:

Also could the LNX version please ignore the case of file names when opening files.

e.g. Mantid converts internally the name of the direct beam file from our user file to all upper case (copying COLETTE here), so on LNX the file has to have an all upper case name.

e.g. Mantid on LNX generates –add files with lower case “–add” appended to name. If these are saved on LNX machine then the SANS batch processor won’t read them as it has also generated an all upper case name. It will read them if you move the files to a windows file directory mapped on the LNX machine!

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:2 Changed 9 years ago by Anders Markvardsen

  • Priority changed from minor to critical

comment:3 Changed 9 years ago by Anders Markvardsen

Richard/Steve strongly preferred if Mantid could be switched to a 'case-insensitive' mode.

Speaking to Martyn this may make sense in other circumstances as well.

Option to accommodate this could be to: Include a Boolean Mantid property, say named caseSentivelyFileFinder. FileFinder will then check the ConfigService and if this property false will search for files case in-sensitively.

comment:4 Changed 9 years ago by Anders Markvardsen

  • Status changed from new to accepted
  • Summary changed from SANS ISIS: make loading of direct beam file case insentive to Make loading of files case insentive by default and user modifyable

Implement:

1) Case insentive by default

2) User option to modify this to case sensitive

comment:5 Changed 9 years ago by Anders Markvardsen

Making Mantid less sensitive. Re #3541

Unit tests to follows

Changeset: 94a80d9a29aab8e57c684df42155d29afcc0dce0

comment:6 Changed 9 years ago by Anders Markvardsen

Unit tests to test on/off case sensitive. Re #3541.

In addition made the on/off mantid property case insentive

Changeset: a0acf0aa7a84f5c01ca09fa1cfdb2ff353408d29

comment:7 Changed 9 years ago by Roman Tolchenov

Re #3541. Quick fix of the builds. Will be followed by proper solution.

Changeset: 29aab9e18d0f6514ee959f81e2d925753701de8a

comment:8 Changed 9 years ago by Anders Markvardsen

Added more sensitivity tests. Re #3541

Changeset: a9b1effa636014e9a7b6d2e0e5978a88608931ae

comment:9 Changed 9 years ago by Anders Markvardsen

Circumvent bug in glob. Re #3541

For some reason when case sensitive is on just discovered that on some occasions this makes poco glob try to make WINDOWS case sensitive...... see comment in glob.cpp

Changeset: 59dea35d6ec4280a08dd1ead9e06d0e2d34000db

comment:10 Changed 9 years ago by Anders Markvardsen

Forgot to uncomment line. Re #3541

Changeset: 6258445a770040160df784817b9eb9f2bc3b7394

comment:11 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:13 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to closed

This works correctly.

There is a hiccup in the unit tests if you have a file in your directories named "CMakeLists.txt~" (emacs backup file). Just as a warning that no one will read.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4388

Note: See TracTickets for help on using tickets.