Ticket #3553 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Update view base class to handle more functionality

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Iteration 30
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

After the addition of new features to the GUI, more common elements and operations have cropped up in the code, especially for the views. The view base class should handle more of those responsibilities to avoid code duplication.

Change History

comment:1 Changed 9 years ago by Michael Reuter

  • Status changed from new to accepted

This will also imply removing the duplicated code from the view classes.

comment:2 Changed 9 years ago by Michael Reuter

In [13988]:

Factor out resets and direct renders to help refactor more code. This refs #3553.

comment:3 Changed 9 years ago by Michael Reuter

In [13989]:

Missed a renaming. This refs #3553.

comment:4 Changed 9 years ago by Michael Reuter

In [13990]:

Removing printout. This refs #3553.

comment:5 Changed 9 years ago by Michael Reuter

In [13991]:

Moving original source and representation to base class. This refs #3553.

comment:6 Changed 9 years ago by Michael Reuter

In [14029]:

Moving all color changing signals/slots to base class. This refs #3553.

comment:7 Changed 9 years ago by Michael Reuter

In [14111]:

Pushing changes into trunk. This refs #3545, #3552, #3553.

comment:13 Changed 9 years ago by Michael Reuter

In [14281]:

Fixing source loading in light of base class functionality. This refs #3553.

comment:14 Changed 9 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:15 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:16 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Good design choice. ViewBase does contain core functionality appropriate to several subclasses. It is used by multiple concrete view types.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4400

Note: See TracTickets for help on using tickets.