Ticket #3555 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Plus for MDEventWorkspace: implement algo

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By: #3558
Blocking: Tester: Peter Parker

Description

Maybe call it PlusMDEW?

The algo will merge two MDEventWorkspaces together by adding events together. Boxes split as needed.

Should handle file-backed MDEW in a reasonable way. Some work towards this has been done already.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

  • Blocked By 3558 added

comment:3 Changed 9 years ago by Janik Zikovsky

In [13939]:

Refs #3555: Stub for PlusMDEW. Fix performance test run.

comment:4 Changed 9 years ago by Janik Zikovsky

In [13968]:

Refs #3555: Plus algorithm for MDEventWorkspaces.

comment:5 Changed 9 years ago by Janik Zikovsky

In [13971]:

Refs #3564: Menu to look at the boxes in a MDEventWorkpsace in MantidPlot. Refs #3555: Better thread safety for the Plus algo and DiskMRU in general.

comment:3 Changed 9 years ago by Janik Zikovsky

In [13986]:

Refs #3555: PlusMDEW with file back end updates the file when done and releases memory.

comment:4 Changed 9 years ago by Janik Zikovsky

In [13992]:

Refs #3555: Disable test to figure out win failure.

comment:5 Changed 9 years ago by Janik Zikovsky

In [14023]:

Refs #3555: MDBox reworked to handle adding events without caching so that PlusMDEW works more efficiently.

comment:6 Changed 9 years ago by Janik Zikovsky

In [14024]:

Refs #3555: Windows try

comment:7 Changed 9 years ago by Janik Zikovsky

In [14026]:

Refs #3555: Disable test that fail on Windows

comment:8 Changed 9 years ago by Janik Zikovsky

In [14044]:

Refs #3555: Fix segfault in a particular case involving the file back end and using PlusMDEW.

comment:9 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Note for testers: Algorithm works with both memory and file-backed workspaces. Performance should be decent for file-backed since it avoids writing out to file all the time. This means that you need to call SaveMDEW with UpdateFileBackEnd to finalize the file!

comment:10 Changed 9 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:11 Changed 9 years ago by Peter Parker

  • Status changed from verifying to closed

Apart from the raised defect #3786, this seems to be working fine.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4402

Note: See TracTickets for help on using tickets.