Ticket #3558 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

CloneWorkspace: implement for MDEventWorkspace

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By: #3561
Blocking: #3555 Tester: Owen Arnold

Description

Perform an exact clone of a MDEventWorkspace.

How should this algorithm handle a file-backed MDEventWorkspace? Should it make a new file-backing or load it to memory? If it makes a new file, where does it stick it?

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

Required for the PlusMDEW algo.

For file-backed: Russell suggests that performing a system file copy will be much quicker than any other way to duplicate it, so I'll just do that.

Last edited 9 years ago by Janik Zikovsky (previous) (diff)

comment:2 Changed 9 years ago by Janik Zikovsky

  • Blocked By 3561 added

comment:3 Changed 9 years ago by Janik Zikovsky

In [13960]:

Fixes #3561: Copy constructors for MDBox, MDGridBox. Refs #3558: CloneWorkspace workspace for file-backed MDEventWorskpace.

comment:3 Changed 9 years ago by Janik Zikovsky

In [13961]:

Refs #3558: Disabled failing test.

comment:4 Changed 9 years ago by Janik Zikovsky

In [13963]:

Refs #3558: CloneMDEventWorkspace in memory

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

In [14207]:

Refs #3557: CloneMDEW has parameter to specify the file.

comment:6 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:7 Changed 9 years ago by Owen Arnold

Verified to create unique copy correctly. Just an idea, but would it be useful to automatically detect the need for and run this algorithm via CloneWorkspace? Inputs and outputs are Mantid::API::IMDEventWorkspace types, so should be possible via Mantid::Algorithms. If this is useful, should definitely occur under a new ticket.

comment:8 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4405

Note: See TracTickets for help on using tickets.