Ticket #3590 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

FindPeaksMD: fixes

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

  • Sort the peaks by bankName then decreasing intensity.
  • Make sure it works with the same output peaks workspace. Dennis reports it hanging after trying to append peaks - it should replace the workspace.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

Also:

  • Make sure the goniometer matrix is copied correctly into each Peak created.
  • Copy the run number to the peak found (if possible).

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Janik Zikovsky

In [14195]:

Refs #3590: MDEWFindPeaks: AppendPeaks option, replace output if not checked. Also sorting output by bankname and intensity.

comment:4 Changed 9 years ago by Janik Zikovsky

In [14199]:

Refs #3590: FindPeaks sets the goniometer and run number in the peaks found. It also knows if the workpsace is in Q lab or Q sample frame. Peaks found are ~ the same from either type of workspace.

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

In [14200]:

Fixes #3590: Fix test.

comment:6 Changed 9 years ago by Janik Zikovsky

  • Summary changed from MDEWFindPeaks: fixes to FindPeaksMD: fixes

comment:7 Changed 9 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:8 Changed 9 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4437

Note: See TracTickets for help on using tickets.