Ticket #3594 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Decide on Rebinning according to WS Type

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Iteration 30
Component: VATES Keywords:
Cc: reuterma.ornl.gov Blocked By:
Blocking: Tester: Michael Reuter

Description

This means that we can support legacy SQW rebinning from a single PV filter. We simply need to decide upon which MVP presenter to use in the paraview plugin according to the type of workspace available. The duplicate PV plugin/filter can be removed entirely. Futhermore, we should only then need a single custom object pannel for the rebinning cutter. Should give much less code to maintain in the future.

IMDWorkspaces should use one MDRebinningPresenter type, IMDEventWorkspaces should use another.

After this change, VatesSimpleGUI will NOT need to provide any conditional statements to choose the correct filter type based on the source.

Change History

comment:1 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Owen Arnold

In [14127]:

refs #3594. Only have one Rebinning Filter now.

comment:3 Changed 9 years ago by Owen Arnold

In [14128]:

refs #3594. Correct warning.

comment:4 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

I have verified that I have not had to change the code to retain the use of both rebinners.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4441

Note: See TracTickets for help on using tickets.