Ticket #3602 (closed: fixed)
Add an option on the Muon FitPropertyBrowser to fit against raw data.
Reported by: | Anders Markvardsen | Owned by: | Robert Whitley |
---|---|---|---|
Priority: | critical | Milestone: | Release 2.0 |
Component: | MantidPlot | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Anders Markvardsen |
Description (last modified by Robert Whitley) (diff)
In MuonAnalysis FitPropertyBrowser the user should be allowed to perform a fitting to the current data as well as the raw data.
This should be implemented as a checkbox where the default is to fit against the current data.
Change History
comment:2 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:5 Changed 9 years ago by Robert Whitley
Refs #3602. Create .cpp and .h files for MuonAnalysisFitDataTab.
Changeset: 77eb9fcc8d1e6c8011f3b535f85b6cd88aa9ca72
comment:6 Changed 9 years ago by Robert Whitley
Refs #3602. Create .cpp and .h files for MuonAnalysisFitDataTab.
Changeset: 77eb9fcc8d1e6c8011f3b535f85b6cd88aa9ca72
comment:7 Changed 9 years ago by Anders Markvardsen
Code for Re #3602.
Changeset: e965d3bcd7bd4a03225e21b3513739a20d34c362
comment:8 Changed 9 years ago by Anders Markvardsen
Restructuring to make use of MuonAnalysisFitDataTab. Re #3602
Changeset: 532b46ea74b37ed28c39186e526f876dc6672ffc
comment:9 Changed 9 years ago by Anders Markvardsen
Minor. Re #3602
Removed a copy of comments I forgot to remove in previous commit to this ticket.
Changeset: 25616daaa17bda31b96329bcc0ad4b2bf74a6c76
comment:10 Changed 9 years ago by Robert Whitley
- Status changed from new to accepted
Anders believes that there shouldn't be a situation where the scientists want to fit raw data to bunched data. This makes things easier because I can concentrate on fitting against raw data.
There are two different ways to fit against raw data.
1) Load up an instance of the raw data and fit against that.
2) When originally loading the data clone the workspace and keep it until needed. Naming it like the other workspaces "name" + "_Raw"
I think that it would be easier to implement the second option. It would also be quicker because cloning a workspace is simple compared to loading a new data file. I can change this once I've done to the more complicated first option if the scientists prefer. (This is a better way of doing it due to no extra workspaces being saved).
comment:11 Changed 9 years ago by Robert Whitley
Refs #3602. Clone the raw data when first loaded into MuonAnalysis
Have it group under the same workspace. Change option on fit browser to Fit To Raw Data to make it clearer what it will do when checked.
Changeset: cab39a770e0d49e8a571f8e82c41be35b6021b2d
comment:12 Changed 9 years ago by Robert Whitley
Refs #3602. Change FitPropertyBrowser so that it can Fit To Raw Data.
Tidy up some unused code.
Changeset: 6abdbb5294e5b2a6a24bb9813edd8c1f7f712065
comment:13 Changed 9 years ago by Robert Whitley
Refs #3602. Change default to fitting against current data.
Also, tidy up the code again.
Changeset: 0e626228e8f681f85d741103957fab4143bedf96
comment:14 Changed 9 years ago by Robert Whitley
- Description modified (diff)
- Summary changed from Add Data row to muon analysis fit browser to Add an option on the Muon FitPropertyBrowser to fit against raw data.
comment:15 Changed 9 years ago by Robert Whitley
Refs #3602. Put code into its own class instead of in MuonAnalysis.cpp
Changeset: fd78d7cc6db19e4cd03cf1821b3f64ebe89ebd42
comment:16 Changed 9 years ago by Robert Whitley
Refs #3602. Use FitDataTab to do all grouping within MuonAnalysis.
This will also reduce code in future for Muon Analysis #3463.
Changeset: 2a93457c6e92a4292fd1a47feb599645b7df8e92
comment:17 Changed 9 years ago by Robert Whitley
- Status changed from accepted to verify
- Resolution set to fixed
comment:18 Changed 9 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:19 Changed 9 years ago by Anders Markvardsen
- Status changed from verifying to closed
Tested on argus0026577. First bin step = 20. Then fit data to raw data, which worked and without raw data clicked which also worked
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4449
Note this ticket is a follow up of #3226