Ticket #3614 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Implement core layout for update Python API

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Set up the package structure and ensure unit tests can be run on both the C++ and Python code.

Change History

comment:1 Changed 9 years ago by Martyn Gigg

In [14203]:

Refs #3614. Check pointing what I've started with the new Python structure. It is NOT included in CMake yet but I want to get the changes in to a safe place.

comment:2 Changed 9 years ago by Martyn Gigg

In [14224]:

More python unit tests and a new instantiator for PythonAlgorithms that means we don't need all that CloneableAlgorithm stuff, we can create a new object as requested. Refs #3614

comment:3 Changed 9 years ago by Martyn Gigg

In [14240]:

Refs #3614. Algorithm exports for [set/get]property along with properties for basic types. An algorithm unit test as well.

comment:4 Changed 9 years ago by Martyn Gigg

In [14241]:

Didn't mean to commit that. Refs #3614

comment:5 Changed 9 years ago by Martyn Gigg

In [14242]:

Refs #3614 Minor fix to unit test

comment:6 Changed 9 years ago by Martyn Gigg

In [14244]:

Small tidy up. Refs #3614

comment:7 Changed 9 years ago by Martyn Gigg

In [14322]:

Further Python work. The tests should now work correctly so I'm activating them on the build server. Refs #3614

comment:8 Changed 9 years ago by Martyn Gigg

In [14323]:

Refs #3614. Fix tests by including explicit string instantiation

comment:9 Changed 9 years ago by Martyn Gigg

In [14324]:

Refs #3614. Fix test.

comment:10 Changed 9 years ago by Martyn Gigg

In [14325]:

Disable C++ python test for time being. Refs #3614

comment:11 Changed 9 years ago by Martyn Gigg

In [14326]:

New Python stuff not quite there on windows yet. Refs #3614

comment:12 Changed 9 years ago by Martyn Gigg

In [14449]:

Much improved handling of the {set,get}property methods but still need to handle downcasts to actual types for get calls. We still end up with just the interface. Refs #3614

comment:13 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:14 Changed 9 years ago by Martyn Gigg

In [14531]:

Refs #3614. Updates to get the Python stuff going on Windows.

comment:15 Changed 9 years ago by Martyn Gigg

In [14532]:

Refs #3614. Forgot a new file

comment:16 Changed 9 years ago by Martyn Gigg

In [14533]:

Refs #3614. A couple of other files.

comment:17 Changed 9 years ago by Martyn Gigg

In [14534]:

Non-windows fix. Refs #3614

comment:18 Changed 9 years ago by Martyn Gigg

In [14535]:

Remove the library prefix on unix. Refs #3614

comment:19 Changed 9 years ago by Martyn Gigg

In [14536]:

Refs #3614. Ensure the mantid target is built on windows.

comment:20 Changed 9 years ago by Martyn Gigg

In [14537]:

Refs #3614. Better fix for ensuring the mantid target is built on windows.

comment:21 Changed 9 years ago by Martyn Gigg

In [14597]:

See if this helps with the Windows 7 clean builds. Refs #3614

comment:22 Changed 9 years ago by Martyn Gigg

In [14694]:

Refs #3614 - Working version of handling setting workspaces correctly. Needs work surrounding passing workspace handles to algorithms that require a name for validation.

comment:23 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:24 Changed 9 years ago by Stuart Campbell

In [14947]:

Added hack so that users are not forced to have LD_LIBRARY_PATH set. refs #3614

comment:25 Changed 9 years ago by Martyn Gigg

In [15054]:

Refs #3614. Add some files that I hadn't checked in yet.

comment:26 Changed 9 years ago by Martyn Gigg

In [15062]:

Refs #3614. Some CMake fiddlng to standardize naming of targets and fix a few tests.

comment:27 Changed 9 years ago by Martyn Gigg

In [15073]:

Refs #3614 Minor CMake fix.

comment:28 Changed 9 years ago by Martyn Gigg

In [15154]:

Merge branch changes back to trunk. Refs #3614

comment:29 Changed 9 years ago by Martyn Gigg

In [15155]:

Refs #3614. Fix a test

comment:30 Changed 9 years ago by Martyn Gigg

Refs #3614. Fix issue with workspace properties when set through a DataItem pointer.

Changeset: 89435032a5573b16bbf5401b819dcf1d4fedde0f

comment:31 Changed 9 years ago by Martyn Gigg

Add a macro for declaring the python type handlers when dealing with properties. Refs #3614

Changeset: 883e3d44b3b87d59d4d00eae7dc6dfbfed6daa2d

comment:32 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

I'm going to close this ticket as the work is now starting to go outside the core setup.

comment:33 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:34 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Have run scripts with new and old python and looked at simpleapi.py and it all looks good to me.

A very minor comment is that a few @param are left out in simpleapi.py

comment:35 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4461

Note: See TracTickets for help on using tickets.