Ticket #3628 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

EQSANS: write workflow algorithm to load data

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

The load script for EQSANS is getting very long. Re-write it as a C++ workflow algorithm.

Change History

comment:1 Changed 9 years ago by Mathieu Doucet

In [14233]:

Checkpoint Re #3628

comment:2 Changed 9 years ago by Mathieu Doucet

In [14234]:

Checkpoint Re #3628

comment:3 Changed 9 years ago by Mathieu Doucet

In [14307]:

Checkpoint Re #3628

comment:4 Changed 9 years ago by Mathieu Doucet

In [14329]:

Checkpoint Re #3628

comment:5 Changed 9 years ago by Mathieu Doucet

In [14352]:

Utility method Re #3628

comment:6 Changed 9 years ago by Mathieu Doucet

In [14354]:

Make rebin in place work for child algorithms Re #3628

comment:7 Changed 9 years ago by Mathieu Doucet

In [14357]:

Checkpoint Re #3628

comment:8 Changed 9 years ago by Mathieu Doucet

In [14372]:

Checkpoint Re #3628

comment:9 Changed 9 years ago by Mathieu Doucet

In [14373]:

Checkpoint Re #3628

comment:10 Changed 9 years ago by Mathieu Doucet

In [14374]:

Make log prettier Re #3628

comment:11 Changed 9 years ago by Mathieu Doucet

In [14393]:

Checkpoint Re #3628

comment:12 Changed 9 years ago by Mathieu Doucet

In [14394]:

Take parameter reading out of the loop. Re #3628

comment:13 Changed 9 years ago by Mathieu Doucet

In [14398]:

Checkpoint Re #3628

comment:14 Changed 9 years ago by Mathieu Doucet

In [14399]:

Checkpoint Re #3628

comment:15 Changed 9 years ago by Mathieu Doucet

In [14400]:

Forgot new ref data. Re #3628

comment:16 Changed 9 years ago by Mathieu Doucet

In [14419]:

Nearly complete EQSANSLoad WorkflowAlg Re #3628

comment:17 Changed 9 years ago by Mathieu Doucet

In [14420]:

Replace bad property name Re #3628

comment:18 Changed 9 years ago by Mathieu Doucet

In [14428]:

First cut complete. Still turned off. Re #3628

comment:19 Changed 9 years ago by Mathieu Doucet

In [14480]:

Fix missing imports Re #3628

comment:20 Changed 9 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:21 Changed 9 years ago by Mathieu Doucet

In [14645]:

Re #3628 preparing to pull plug on old python script

comment:22 Changed 9 years ago by Mathieu Doucet

In [14712]:

Get rid of old code. Re #3628

comment:23 Changed 9 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

To test: The old python code has been removed. To test, just run any EQSANS system test.

comment:24 Changed 9 years ago by Mathieu Doucet

In [14714]:

Get rid of old code. Re #3628

comment:25 Changed 9 years ago by Mathieu Doucet

In [14720]:

Get rid of old code. Re #3628

comment:26 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:27 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

I picked the EQSANSBeamCenter and EQSANSTrans test and everything ran without complaint.

comment:28 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4475

Note: See TracTickets for help on using tickets.