Ticket #3629 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

UnwrapSNS for inplace histogram

Reported by: Peter Peterson Owned by: Vickie Lynch
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Just to write up Vickie's analysis of the error: 

... unwrap algorithm works great for histograms when the input and output 
workspaces are different. When they are the same the vector insert gets an 
out of bounds error. I think the vector clear also clears the input vector 
but did not have time to fix.

Attachments

UnwrapSNStest.png​ (332.0 KB) - added by Vickie Lynch 9 years ago.
Small differences with Unwrap of 62

Change History

comment:1 Changed 9 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Vickie Lynch

In [14265]:

Refs #3629 UnwrapSNS fix for inplace histograms

comment:3 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:5 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This doesn't seem to do anything for CNCS data. Should it?

comment:6 Changed 9 years ago by Vickie Lynch

  • Status changed from reopened to accepted

Changed 9 years ago by Vickie Lynch

Small differences with Unwrap of 62

comment:7 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Hi Michael, I have attached a screenshot that show differences in using UnwrapSNS

comment:8 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:9 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

OK, this looks to be doing what it should be doing.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4476

Note: See TracTickets for help on using tickets.