Ticket #3653 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

FunctionTest & CompositeFunctionTest should not reference Workspace2D

Reported by: Russell Taylor Owned by: Roman Tolchenov
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The fact that they do is an implicit dependency on a higher package, which is wrong. You'll need to use a fake MatrixWorkspace implementation instead (such as those in MatrixWorkspaceTest and WorkspaceFactoryTest) - or perhaps it's an opportunity to learn about gmock.

Change History

comment:1 Changed 9 years ago by Roman Tolchenov

  • Status changed from new to verify
  • Resolution set to fixed

In [14410]:

Implemented derivative calculation for MultiBG, changed many int to size_t in functions. re #966. Removed references to Workspace2D from API/CompositFunctionTest and API/FunctionTest, fixes #3653.

comment:2 Changed 9 years ago by Mathieu Doucet

In [14430]:

Fixing warnings Re #966 and #3653

comment:3 Changed 9 years ago by Mathieu Doucet

In [14431]:

Fixing warnings Re #966 and #3653

comment:4 Changed 9 years ago by Mathieu Doucet

In [14432]:

Fixing warnings Re #966 and #3653

comment:5 Changed 9 years ago by Mathieu Doucet

In [14433]:

Fixing warnings Re #966 and #3653

comment:6 Changed 9 years ago by Mathieu Doucet

In [14435]:

Fixing warnings Re #966 and #3653

comment:7 Changed 9 years ago by Mathieu Doucet

In [14437]:

Fixing warnings Re #966 and #3653

comment:8 Changed 9 years ago by Mathieu Doucet

In [14439]:

Fixing warnings Re #966 and #3653

comment:9 Changed 9 years ago by Mathieu Doucet

In [14448]:

Fixing warnings Re #966 and #3653

comment:10 Changed 9 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:11 Changed 9 years ago by Russell Taylor

  • Status changed from verifying to closed

These tests no longer reference the real Workspace2D.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4500

Note: See TracTickets for help on using tickets.