Ticket #3676 (closed: fixed)
Windows installer includes all header files
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Iteration 30 |
| Component: | Mantid | Keywords: | |
| Cc: | taylorrj@…, nick.draper@… | Blocked By: | |
| Blocking: | Tester: | Russell Taylor |
Description
A recent checking caused the number of files that wxs processes to exceed 10000 and the file ID that the script generated went over the 8.3 character limit on windows. This can be fixed rather easily but it appears we ship all of our includes in the installer. Do we need to do this? Should we not just ship Kernel, Geometry and API?
Change History
comment:2 Changed 9 years ago by Martyn Gigg
I think it's boost that gives us that near that level. It's not just headers either it's probably the python includes as well.
comment:3 Changed 9 years ago by Russell Taylor
It would certainly help the download size if we didn't ship all the boost headers (135M uncompressed). Though stripping it down to only those we use would likely lead to maintenance issues down the road (ameliorated if we had an automated check of some kind).
comment:4 Changed 9 years ago by Martyn Gigg
Agreed. The problem with trying to automate it is being able to pick up which headers are then used by the ones we include. Visual Studio has a /showincludes switch which could be used in a small isolated program to pick them up, it shouldn't be too difficult to write.
comment:18 Changed 9 years ago by Martyn Gigg
In [14611]:
comment:19 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:20 Changed 9 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Martyn Gigg
- Milestone changed from Iteration 31 to Iteration 30
comment:21 Changed 9 years ago by Martyn Gigg
The immediate problem is been solved and the installers work again.
A long term solution is suggested here: #3739
comment:23 Changed 9 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:24 Changed 9 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:25 Changed 9 years ago by Russell Taylor
- Status changed from verifying to closed
The installer now only includes the headers for Kernel, Geometry, API & NexusCPP - plus boost, Poco & napi.h - and is (a bit - about 3MB) smaller. Confirmed that I was able to build UserAlgorithms off of what's provided.
comment:26 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4523
Definitely. And the (extremely) new NexusCPP. (Do we really have >10,000 headers?!)