Cull uses of ExperimentInfo::getBaseInstrument()

[Russell Taylor]

I suspect that the vast majority (all?) of such calls are unnecessary, and should either be calling just getInstrument() or (especially in the tests) are just getting hold of a pristine instrument to modify - in which case they could just create a new instrument and use setInstrument().

[Russell Taylor]

In [14581]:

Eliminate calls to getBaseInstrument in tests. Re #3690.

[Russell Taylor]

In [14582]:

ExperimentInfo::getBaseInstrument() is gone. If it's really necessary to get hold of the 'naked' instrument then there's a baseInstrument() method on Instrument itself - but it should only be rarely needed. Re #3690.

[Russell Taylor]

In [14583]:

Forgot to check MantidPlot. Re #3690.

[Russell Taylor]

In [14598]:

Eliminate calls to baseInstrument() that should be using getComponentID() instead. Re #3690.

[Russell Taylor]

ExperimentInfo::getBaseInstrument is no more. The corresponding method Instrument::baseInstrument (which returned the same thing) is used only 8 times in the code (and 12 in the tests), which is suitably rare.

[Martyn Gigg]

grep returns nothing for getBaseInstrument and a few references to baseInstrument.

Some baseInstrument calls could be removed (some are things that I need to do!).

[Stuart Campbell]

This ticket has been transferred to github issue ​4537