MoveInstrumentComponent & RotateInstrumentComponent code duplication

[Russell Taylor]

As well as being duplicated between the 2 algorithms, aren't the findByID() & findByName() methods duplicating functionality that's available on Geometry classes?

[Karl Palmen]

A look at the code suggestes that the duplicated code should belong to the ICompAssembly or CompAssembly class.

[Karl Palmen]

Further investigation shows that both the duplicate functions are private and findByName is never used. Instead I see a call of the getComponentByName member function of class Instrument.

I see that class instrument also has a member function called GetComponentByID. Further examination shows this is not used because its ID is a component ID, which is quite different from the detector ID used by findByID.

Now it seems that findByID could be replaced by getComponentByDetectorID of class instrument, using (almost) the same code.

[Russell Taylor]

Instrument::getDetector retrieves a detector based on the detector ID that this algorithm is using.

[Karl Palmen]

In [14955]:

Removed functions findByName and findByID from the MoveInstrumentComponent and RotateInstrumentComponent and replace calls of them by appropriate member functions of instrument. re #3709

[Karl Palmen]

The appropriate function for findByName was already in use and the approprate function for findByID was getComponentByDetectorID, which was suggested by Russell.

[Karl Palmen]

Resolved as stated last week.

[Stuart Campbell]

This ticket has been transferred to github issue ​4556