Ticket #3711 (closed: duplicate)
Performance degradation in DiffractionFocussing
| Reported by: | Russell Taylor | Owned by: | Vickie Lynch |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
Changeset [14427] caused some of the DiffractionFocussing performance tests to slow down significantly: test_SNAP_event_six_groups_dontPreserveEvents slowed down by about 50% and test_SNAP_event_one_group_dontPreserveEvents by a lesser, but still noticeable amount.
At least a third of the total time being in this one addition seems like a lot - it should be checked if something can be done to improve this.
Attachments
Change History
Changed 9 years ago by Russell Taylor
comment:1 Changed 9 years ago by Russell Taylor
- Status changed from new to assigned
- Owner set to Vickie Lynch
Vickie, could you take a look as this was your check-in? If you can't get anywhere let me know. Some slowdowns may just be necessary, but I'm going to create tickets when I spot things so they at least get looked at.
comment:2 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:3 Changed 9 years ago by Vickie Lynch
- Status changed from assigned to accepted
May try to use OpenMP like event diffraction focussing.
comment:4 Changed 9 years ago by Russell Taylor
DiffractionFocussing2TestPerformance.test_SNAP_event_one_group took a similarly big hit when I introduced the same check for masked detectors in [14837]. This check seems surprisingly slow, and I will need to look into why this is.
(N.B. Trying to use OpenMP if possible sounds like a good idea in any case.)
comment:5 Changed 9 years ago by Vickie Lynch
Refs #3711 Parallel loops for diffraction focussing histograms
Changeset: 5d204f3575812ced8a8c43ac185da099bd975c14
comment:6 Changed 9 years ago by Vickie Lynch
Refs #3711 readX,Y,Z not dataX,Y,Z
Changeset: 8f06d1fffec8895a8a14edadf98dc06a69e8aa4b
comment:7 Changed 9 years ago by Vickie Lynch
Revert "Refs #3711 readX,Y,Z not dataX,Y,Z"
This reverts commit 8f06d1fffec8895a8a14edadf98dc06a69e8aa4b.
Changeset: 95074243b1288c71141c2290b6d22f0f8fb4e027
comment:8 Changed 9 years ago by Vickie Lynch
Revert "Refs #3711 Parallel loops for diffraction focussing histograms"
This reverts commit 5d204f3575812ced8a8c43ac185da099bd975c14.
Changeset: 17d4c3daef2e789e64639d6cc9b43a9364722de9
comment:9 Changed 9 years ago by Vickie Lynch
Refs #3711 Parallel loops for diffraction focussing histograms
Changeset: 3c05640633cac881473f7c8bff07b1c9d356b27c
comment:10 Changed 9 years ago by Vickie Lynch
Refs #3711 Check masked detectors from workspace
Changeset: 2a3d8a8c8e37886daeaad20f0671dbe783349625
comment:11 Changed 9 years ago by Vickie Lynch
Refs #3711 Check masked detectors inside Parallel_CRITICAL
Changeset: 6d355db75ffd2195ef0669ff776e2b7e326a8f45
comment:12 Changed 9 years ago by Vickie Lynch
Refs #3711 Back to yesterday's DiffractionFocussing2
Changeset: 61e00c060d60c56516b511d0f1f366822ff75c7d
comment:13 Changed 9 years ago by Vickie Lynch
- Status changed from accepted to verify
- Resolution set to duplicate
This ticket was done in #4208. All changes commited were removed, so there is nothing to test.
comment:14 Changed 9 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:15 Changed 9 years ago by Nick Draper
Verified that changes were rolled back, duplicate approved
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4558
Chart showing the jump in time taken