Ticket #3716 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

LoadTofRawNexus: add option to choose the signal

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Iteration 30
Component: Mantid Keywords:
Cc: pf9@…, scu@… Blocked By:
Blocking: Tester: Peter Peterson

Description

... for NOMAD's live nexus runs, histograms in d, q, and tof are being generated.

Add a parmeter called "Signal", an int, default 1. The signal attribute of NXS data fields will be used to find the right data to load. Use the axes attribute (if present) to find the name of the X-axis (normally time_of_flight) giving the binning parameters.

Test file at :

/SNS/users/y8y/NOM_2011_09_13T20_59_00Z_histo.nxs

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

In [14629]:

Refs #3716: Find an entry to load in TOFRAW nxs file.

comment:3 Changed 9 years ago by Janik Zikovsky

In [14630]:

Refs #3716

comment:4 Changed 9 years ago by Janik Zikovsky

In [14631]:

Refs #3716

comment:5 Changed 9 years ago by Janik Zikovsky

In [14632]:

Refs #3716: More support for other signals, but not fully tested because the pixel_id field in the sample file is missing.

comment:6 Changed 9 years ago by Janik Zikovsky

In [14651]:

Refs #3716: More support for choosing signals. Ignores missing metadata. Finds instrument name from filename if not present in file. NXS routines support different entry names. Parallelized LoadTofRawNexus.

comment:7 Changed 9 years ago by Janik Zikovsky

In [14652]:

Refs #3716: Test runs with less memory use

comment:8 Changed 9 years ago by Janik Zikovsky

In [14658]:

Refs #3716: Not sure why failing on other systems.

comment:9 Changed 9 years ago by Janik Zikovsky

In [14667]:

Refs #3716: LoadTOFRawNexus works with the latest Live NXS file.

comment:10 Changed 9 years ago by Janik Zikovsky

In [14670]:

Refs #3716: Declared algo as a Load algorithm and added methods to check file.

comment:11 Changed 9 years ago by Janik Zikovsky

In [14671]:

Refs #3716: More tests

comment:12 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

In [14675]:

Fixes #3716: Test disabled fow now. Note to testers: try on RHEL5/6, Fedora and OpenSuse to make sure the algo works.

comment:13 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:14 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This segfaults on /SNS/NOM/shared/live/NOM_2011_09_20T12_59_50Z_histo.nxs

comment:15 Changed 9 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:16 Changed 9 years ago by Janik Zikovsky

In [14802]:

Refs #3716: Put a mutex to allow OpenMP on RHEL/Fedora. Will have to wait for build servers to see if it worked.

comment:17 Changed 9 years ago by Janik Zikovsky

In [14803]:

Refs #3716: Mutex did not help for some OS's. Try with no OpenMP loop at all.

comment:18 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Works on all OSs if not parallel.

comment:19 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying

comment:20 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to closed

The data appears to load in, but the extra views appear to be empty. I think it is the file and not the algorithm.

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4563

Note: See TracTickets for help on using tickets.