Ticket #3725 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Mac compiler warnings from calls to IFunctionMW::setMatrixWorkspace

Reported by: Russell Taylor Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

Consider the warnings listed at ​http://download.mantidproject.org/jenkins/view/ISIS%20clean%20builds/job/isis_clean_snowleopard/138/warningsResult/?

They all relate to calls to IFunctionMW::setMatrixWorkspace with the last two arguments set to -1. These arguments changed to size_t in [14410]. Consider carefully if it's safe to end up with very large numbers in these variables (max size_t - 1) and if so remove the warning. Perhaps this method should have defaulted arguments?

Change History

comment:1 Changed 9 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:3 Changed 9 years ago by Roman Tolchenov

In [15112]:

re #3725. Changed the function signature.

comment:4 Changed 9 years ago by Roman Tolchenov

In [15115]:

re #3725. Fixing the tests

comment:5 Changed 9 years ago by Roman Tolchenov

In [15116]:

re #3725. Clearing warnings

comment:6 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:8 Changed 9 years ago by Nick Draper

  • Status changed from verifying to closed

verified that the warnings are cleared

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4572

Note: See TracTickets for help on using tickets.