Ticket #3738 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Load Dialog can crash: when no loader found

Reported by: Nick Draper Owned by: Peter Parker
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

Try to load a file for which no loader volunteers ( e.g. a text file from saveascii with no .txt extension).

Crash when clicking Run

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Owner changed from Anyone to Peter Parker
  • Status changed from new to assigned

comment:2 Changed 9 years ago by Peter Parker

In [15063]:

Fixed the case where no loader volunteers when running the Load algo (say for a nonsensical file with incorrect/missing extension) and Mantid would crash as a result. I was however unable to produce a crash by loading a file with a correct format but incorrect/missing file extension. Perhaps this has been fixed elsewhere. Also made a change to LoadRawHelper.cpp to cover a case where we were trying to directly access a character at a particular index of a string which is sometimes empty. - (Refs #3738)

comment:3 Changed 9 years ago by Peter Parker

  • Status changed from assigned to accepted

comment:4 Changed 9 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:6 Changed 9 years ago by Nick Draper

  • Status changed from verifying to closed

tested with unknown text file

C:/eula.1033.txt

passed

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4585

Note: See TracTickets for help on using tickets.