Ticket #3743 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Restore erroneously commented out MantidPlot virtual methods

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 30
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

I failed to use my brain when commenting out a bunch of methods that caused Intel compiler warnings. I blindly trusted Eclipse when it told me the methods weren't called without thinking how virtual methods work, and how Eclipse doesn't know about the third party source code.

The fix to #3731 involved restoring on such method - I should put back the other places I did this and worry about the warnings later.

Change History

comment:1 Changed 9 years ago by Russell Taylor

In [14764]:

Restore virtual methods that shouldn't have been commented out. Re #3743.

comment:2 Changed 9 years ago by Russell Taylor

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

Ticket #3744 created to clear the resulting compiler warnings after the release.

comment:4 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:5 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to closed

Russell successfully uncommented code.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4590

Note: See TracTickets for help on using tickets.