Ticket #3749 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

PG3_5476 does not work in SNSPowderReduction

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: critical Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

There is a problem when using RemovePromptPulse which sets the time windows such that MaskBins does generates an error about xmin being greater than xmax.

Change History

comment:1 Changed 9 years ago by Peter Peterson

  • Owner set to Peter Peterson
  • Status changed from new to accepted

comment:2 Changed 9 years ago by Peter Peterson

In [14769]:

Adding better error message with the specific values that don't work. Refs #3749.

comment:3 Changed 9 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

In [14770]:

Verify that the mask range will do something before running MaskBins. Fixes #3749.

comment:4 Changed 9 years ago by Peter Peterson

Here is the important excerpt from running SNSPowderReduction with the run in question: 

$ bin/MantidPlot 
SNSPowderReduction-[Notice] SNSPowderReduction started
LoadEventNexus-[Notice] LoadEventNexus started
LoadEventNexus-[Notice] LoadEventNexus successful, Duration 10.30 seconds
LoadCalFile-[Notice] LoadCalFile started
LoadCalFile-[Warning] 3 errors (invalid Detector ID's) found when reading .cal file '/SNS/PG3/2011_2_11A_CAL/PG3_FERNS_d4832_2011_08_24.cal'.
LoadCalFile-[Notice] LoadCalFile successful, Duration 0.52 seconds
FilterBadPulses-[Notice] FilterBadPulses started
FilterBadPulses-[Notice] FilterBadPulses successful, Duration 2.73 seconds
RemovePromptPulse-[Notice] RemovePromptPulse started
RemovePromptPulse-[Notice] Filtering tmin=16665, tmax=16715 microseconds
RemovePromptPulse-[Notice] RemovePromptPulse successful, Duration 12.02 seconds
CompressEvents-[Notice] CompressEvents started
CompressEvents-[Notice] CompressEvents successful, Duration 0.40 seconds
SortEvents-[Notice] SortEvents started
SortEvents-[Notice] SortEvents successful, Duration 0.02 seconds
MaskDetectors-[Notice] MaskDetectors started
MaskDetectors-[Warning] No spectra affected.
MaskDetectors-[Notice] MaskDetectors successful, Duration 0.09 seconds
AlignDetectors-[Notice] AlignDetectors started
AlignDetectors-[Notice] AlignDetectors successful, Duration 1.38 seconds

The crash used to happen before AlignDetectors. Now lucky tester, you can close the ticket as you have objective evidence that it is fixed.

comment:5 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

Yes, this works without crashing.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4596

Note: See TracTickets for help on using tickets.