Ticket #3763 (assigned)

Opened 9 years ago

Last modified 5 years ago

Dynamic property validation

Reported by: Martyn Gigg Owned by: Anyone
Priority: minor Milestone: Backlog
Component: Framework Keywords:
Cc: taylorrj@… Blocked By:
Blocking: #3925 Tester:

Description

At present, the NormaliseToMonitor algorithm requires that you enter the spectrum number relating to the monitor you wish to use. It would be much nicer, particularly when using MantidPlot, to give the name of the monitor instead. But this isn't known until the input workspace has been set, so we would need to find a way in which the setting of the input workspace fired an event that the monitor property could catch and update itself.

Span off from #262

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to assigned

After thinking of a solution it should be discussed via mantid.developers@… before implementation

comment:2 Changed 9 years ago by Alex Buts

This feature will be extremely useful for multidimensional algorithm creation, as the dimensions, available for MD algorithms depend on user input and the log values, present in a workspace. Namely: 1) Number of dimension properties is defined by the user's input into Num_dimensions field

2) The dimension properties are the lists of strings, partially derived from the log names present in the input workspace

3) Two different dimension property can not provide the same value from the list (this can be of course checked during the algorithm execution but will be nicer on properties)

comment:3 Changed 9 years ago by Alex Buts

  • Blocking 3925 added

comment:3 Changed 9 years ago by Alex Buts

In [15304]:

refs #3925 first and wrong attempt to use/create dynamic properties to generate ConvertToN-dimensions algorithm.
Apparently, this ticket is bind with ticket refs#3763

comment:5 Changed 9 years ago by Alex Buts

refs #3925, refs #3763 initial attempt to implement signaling validators

Changeset: d07ca5327f62dd36639076e6400f50abcfd98fab

comment:6 Changed 9 years ago by Alex Buts

refs #3763 fixing Unix error

Changeset: 7671abb942a4c9e194f56c18658dbdf9f86eb0ae

comment:7 Changed 9 years ago by Alex Buts

refs #3763 fixing unix error

Changeset: c49fb86af29874cef246796b00e0d35f7f669b49

comment:8 Changed 9 years ago by Alex Buts

refs #3763 added allowedValue function to CompositeValidator.cpp

Changeset: 6b9f6e45817ec5b6adb9a122d9a65f909eb77811

comment:9 Changed 9 years ago by Alex Buts

refs #3925, refs #3763 initial attempt to implement signaling validators

Changeset: d07ca5327f62dd36639076e6400f50abcfd98fab

comment:10 Changed 9 years ago by Alex Buts

refs #3763 fixing Unix error

Changeset: 7671abb942a4c9e194f56c18658dbdf9f86eb0ae

comment:11 Changed 9 years ago by Alex Buts

refs #3763 fixing unix error

Changeset: c49fb86af29874cef246796b00e0d35f7f669b49

comment:12 Changed 9 years ago by Alex Buts

refs #3763 fixing warning and couple of comments

Changeset: 25e85e1515dfcbac705e78364c0bb1a9b3b99719

comment:13 Changed 9 years ago by Alex Buts

refs #3763 fixing warning and couple of comments

Changeset: 3d6ff6f66464f1b9cdb2775fc596ebf3a9362303

comment:14 Changed 9 years ago by Alex Buts

refs #3763 Fixing Unix build

Changeset: eb9c8b25b8e171dec2b6c452ce321079654689eb

comment:15 Changed 9 years ago by Alex Buts

refs #3763 Fixing Unix warning

(to see where the error actually come from)

Changeset: 3a92482c70994464c990e6a91f59fa51ec137806

comment:16 Changed 9 years ago by Alex Buts

refs #3763 Attempt to fix unix build

Changeset: 410166af8f20a95456dacf1e5c43ca9aeca3cb63

comment:17 Changed 9 years ago by Alex Buts

refs #3763 Warnings&comments

Changeset: 991a84c7b83010e00eb4674edcf2e07b79576fb2

comment:18 Changed 9 years ago by Alex Buts

refs #3763 Crude implementation of Dynamic properties.

Will not work properly form framework when property modifier change validator in such a way, that old value of the dependent property is incorrect. Substantial changes needed to rectify that and to avoid such situation, so currently has to be dealt with by user.

It would be also beneficial to implement proper notification mechanism, which would inform the property about the changes in the properties it depends on, as current implementation can potentially have substantial overhead, which user should be really carefull about.

Changeset: c8d3a5aaaae6a7f69d0522bcfec333b870dc23f3

comment:19 Changed 9 years ago by Alex Buts

refs #3763 Fixing Unix build

Changeset: eb9c8b25b8e171dec2b6c452ce321079654689eb

comment:20 Changed 9 years ago by Alex Buts

refs #3763 Fixing Unix warning

(to see where the error actually come from)

Changeset: 3a92482c70994464c990e6a91f59fa51ec137806

comment:21 Changed 9 years ago by Alex Buts

refs #3763 Attempt to fix unix build

Changeset: 410166af8f20a95456dacf1e5c43ca9aeca3cb63

comment:22 Changed 9 years ago by Alex Buts

refs #3763 Warnings&comments

Changeset: 991a84c7b83010e00eb4674edcf2e07b79576fb2

comment:23 Changed 9 years ago by Alex Buts

refs #3763 Crude implementation of Dynamic properties.

Will not work properly form framework when property modifier change validator in such a way, that old value of the dependent property is incorrect. Substantial changes needed to rectify that and to avoid such situation, so currently has to be dealt with by user.

It would be also beneficial to implement proper notification mechanism, which would inform the property about the changes in the properties it depends on, as current implementation can potentially have substantial overhead, which user should be really carefull about.

Changeset: c8d3a5aaaae6a7f69d0522bcfec333b870dc23f3

comment:24 Changed 9 years ago by Alex Buts

refs #3763 ValidatorSignalChange.h removed

Changeset: edbe935d3fe0150d755748beaa31c5d67ff0922f

comment:25 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:26 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:27 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

comment:28 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:29 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:30 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:31 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:32 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:33 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:34 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:35 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4610

Note: See TracTickets for help on using tickets.