Ticket #3769 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

WorkspaceFactoryImpl::initializeFromParent replaces a RefAxis with a NumericAxis

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Iteration 30
Component: Mantid Keywords:
Cc: alex.buts@… Blocked By: #3777
Blocking: Tester: Martyn Gigg

Description

....when it shouldn't.

Change History

comment:1 Changed 9 years ago by Russell Taylor

  • Cc alex.buts@… added
  • Status changed from new to accepted

comment:2 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

In [14804]:

Minimal changes to fix #3769 - isolated to 1 new method in Axis (& subclasses) and the single place in WorkspaceFactory that needs to call it.

comment:3 Changed 9 years ago by Russell Taylor

Ticket #3775 has been created to review our use of the Axis classes in a future iteration.

comment:4 Changed 9 years ago by Russell Taylor

  • Tester set to Martyn Gigg

comment:5 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying

comment:6 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Tested in two ways:

Loaded a file and used CropWorkspace to shrink the size in both directions and also used CloneWorkspace to keep the size the same to check both routes through the code.

In [14803]: CropWorkspace causes a change from RefAxis -> NumericAxis and the values are also incorrect, CloneWorkspace leaves it alone. In [14805](Todays test vesion): The output from both CropWorkspace and CloneWorkspace now have a RefAxis on axis 0 and the values from the CropWorkspace version now match the X values in the workspace correctly.

Also tested that the other workspace meta information has not been affected.

comment:7 Changed 9 years ago by Russell Taylor

  • Blocked By 3777 added

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4618

Note: See TracTickets for help on using tickets.