Ticket #3782 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Mask2Cal: algorithm to convert mask workspaces into cal files

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: blocker Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Nick Draper) (diff)

A python algorithm that will convert mask workspaces into cal files.

This converts the masked detectors into a focussing group. select and offsets values will be entered as defaults.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Description modified (diff)

comment:2 Changed 9 years ago by Roman Tolchenov

  • Status changed from new to verify
  • Resolution set to fixed

In [14814]:

Added MaskWorkspaceToCalFile python algorithm which fixes #3782

comment:3 Changed 9 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:4 Changed 9 years ago by Janik Zikovsky

Why not use the the SaveCalFile algorithm?

comment:5 Changed 9 years ago by Russell Taylor

SaveCalFile doesn't do quite the same thing as this algorithm, in that it toggles the 'select' column rather than the 'group' column based on the mask value (group always being 1 in this case). It also bases its output on the instrument rather than the workspace (e.g. monitors end up in the file even if they're not in the input workspace).

Having said that, DiffractionFocussing fails on the output of MaskWorkspaceToCalFile - which I tried by generating the file off a MaskWorkspace created by the InstrumentWindow, and also by first running LoadCalFile to create the mask workspace (note that this is different to the instrument view one - it is of type 'SpecialWorkspace2D' and includes all pixels whereas the instrument view one appears to only include the first pixel in a group - it steps by 4 for WISH - which is probably not be the right thing to do).

DiffrationFocussing works on a cal file generated by LoadCalFile followed by SaveCalFile.

comment:6 Changed 9 years ago by Nick Draper

  • Status changed from verifying to verify
  • Tester Russell Taylor deleted

comment:7 Changed 9 years ago by Nick Draper

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:8 Changed 9 years ago by Roman Tolchenov

In [14823]:

DetectorGroups are taken into account. re #3782

comment:9 Changed 9 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:10 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 9 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:12 Changed 9 years ago by Russell Taylor

  • Status changed from verifying to closed

The produced file now expands out detector groups correctly. DiffractionFocussing works in the scenarios described above. Since the mask workspace from the instrument view holds the detector grouping internally, I would think there's no problem there after all.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4629

Note: See TracTickets for help on using tickets.