Ticket #3806 (closed: fixed)
Force style to 'line' for MuonAnalysis fit curves
| Reported by: | Anders Markvardsen | Owned by: | Robert Whitley |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Anders Markvardsen |
Description
Somehow figure out how to force Mantid to allow the style of the fitting curves generated from Data Analysis to have plot style 'line' (and e.g. not 'line+symbol'). This ticket is related to #2378
Change History
comment:2 Changed 9 years ago by Robert Whitley
In [15211]
Added code for this purpose, is a little bit buggy at the moment. If you do a fitting using something other than line (i.e scatter) then it will only work once. If you try to re-fit the same curve then it will plotted using the line style regardless of what the user has selected.
comment:4 Changed 9 years ago by Robert Whitley
Need to change the default symbol to eclipse with no fill.
comment:5 Changed 9 years ago by Robert Whitley
I've changed the default symbol for scatter points to an ellipse because feedback from the Muon scientists was that the cross was too hard to see.
https://github.com/mantidproject/mantid/commit/17e4d1025e8102866e85a599045f18e28e1e616a
comment:7 Changed 9 years ago by Robert Whitley
Refs #3806. Added more functionality and matched up signals and slots to do the customisation. The plot now gets updated with a fit and when plotting the guess. One bug remains which is after a fitting is done for the second time the fit curve doesn't change.
Changeset: 5d985ce4e3b076af4f36069e3c6357b488eaa89a
comment:8 Changed 9 years ago by Robert Whitley
Refs #3806. Fixed the bug that only allowed for one fitting with a specified curve type.
Changeset: f8738887de4d1c5f1df71f56e3a1f05cf24640c6
comment:9 Changed 9 years ago by Robert Whitley
- Status changed from accepted to verify
- Resolution set to fixed
comment:10 Changed 9 years ago by Robert Whitley
- Status changed from verify to reopened
- Resolution fixed deleted
comment:11 Changed 9 years ago by Robert Whitley
Refs #3806. Fixed the need to click the graph or change tab in order to replot the graph and show the customisation requested by the user.
Changeset: ad2afea575a722f6e85212057e03daaff689bf7e
comment:12 Changed 9 years ago by Robert Whitley
Refs #3806. Can now accept any kind of axis label and still customise the fitting.
Changeset: 367a37dc7a9f5938f9f8e791b871e3531377079c
comment:14 Changed 9 years ago by Robert Whitley
- Status changed from accepted to verify
- Resolution set to fixed
comment:15 Changed 9 years ago by Robert Whitley
Refs #3806. Added more functionality and matched up signals and slots to do the customisation. The plot now gets updated with a fit and when plotting the guess. One bug remains which is after a fitting is done for the second time the fit curve doesn't change.
Changeset: 5d985ce4e3b076af4f36069e3c6357b488eaa89a
comment:16 Changed 9 years ago by Robert Whitley
Refs #3806. Fixed the bug that only allowed for one fitting with a specified curve type.
Changeset: f8738887de4d1c5f1df71f56e3a1f05cf24640c6
comment:17 Changed 9 years ago by Robert Whitley
Refs #3806. Fixed the need to click the graph or change tab in order to replot the graph and show the customisation requested by the user.
Changeset: ad2afea575a722f6e85212057e03daaff689bf7e
comment:18 Changed 9 years ago by Robert Whitley
Refs #3806. Can now accept any kind of axis label and still customise the fitting.
Changeset: 367a37dc7a9f5938f9f8e791b871e3531377079c
comment:19 Changed 9 years ago by Mathieu Doucet
Re #3806 Fix broken signal for range update
Changeset: 36d2c8e0eac8bd7f9d1bbb948b8790add1235fa5
comment:20 Changed 9 years ago by Mathieu Doucet
Re #3806 Allow for FitPropertyBrowser not to be shown
Changeset: fa4164904fcb190997b2487790e4d04393d6d720
comment:21 Changed 9 years ago by Robert Whitley
- Status changed from verify to reopened
- Resolution fixed deleted
comment:22 Changed 9 years ago by Robert Whitley
comment:23 Changed 9 years ago by Mathieu Doucet
Re #3806 Fix broken signal for range update
Changeset: 36d2c8e0eac8bd7f9d1bbb948b8790add1235fa5
comment:24 Changed 9 years ago by Mathieu Doucet
Re #3806 Allow for FitPropertyBrowser not to be shown
Changeset: fa4164904fcb190997b2487790e4d04393d6d720
comment:25 Changed 9 years ago by Robert Whitley
Refs #3806. Fix guess not changing the style.
Fitting a function as a scatter merges the default line and the user choice of scatter to form a mixed version for the fit of symbol+line.
Changeset: 795cb7431afb584e305bab02810c578fda397a4b
comment:26 Changed 9 years ago by Robert Whitley
Defect caused by grouping workspaces. Need a way to customise the workspaces after the grouping has taken place.
comment:27 Changed 9 years ago by Robert Whitley
Refs #3806. Fix fitting having only one style.
Still need to find fix for applying scatter to either fit or data. Plotting guess with temporarily solve it and change symbol+line to scatter.
Changeset: 3537aa6feb6b798bc9540ed089c9b2b19e75c519
comment:28 Changed 9 years ago by Robert Whitley
- Status changed from reopened to accepted
Talking to the Muon scientists they have told me to drop the option to format the fitting curve.
This should be a straight line and therefore changing its plot style wouldn't make any difference. It was also causing confusion because they thought it would change the points of the main data set and not the points on the fitting.
comment:29 Changed 9 years ago by Robert Whitley
Refs #3806. After feedback from muon guys take out fitting format.
Change the grouping of workspaces so that it uses an algorithm instead of python. This will be able to use a grouping function in the FitDataTab when it is implemented.
Changeset: b68b143fd3826c38e250ea7b145ba3e5a45d5649
comment:30 Changed 9 years ago by Robert Whitley
Refs #3806. After feedback from muon guys take out fitting format.
Change the grouping of workspaces so that it uses an algorithm instead of python. This will be able to use a grouping function in the FitDataTab when it is implemented.
Changeset: b68b143fd3826c38e250ea7b145ba3e5a45d5649
comment:31 Changed 9 years ago by Robert Whitley
- Status changed from accepted to verify
- Resolution set to fixed
Ticket #4406 has been created which addresses the issue of fitting data and it losing its format.
Will close this ticket as fixed so that it is included for testing.
comment:32 Changed 9 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:33 Changed 9 years ago by Anders Markvardsen
- Status changed from verifying to closed
Tested this works for:
Load current and dataset from AutoTestData
comment:34 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4653
