Ticket #3819 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

ICAT: Incorrect login to Catalog does not show an appropriate response

Reported by: Karl Palmen Owned by: Jay Rainey
Priority: major Milestone: Release 3.0
Component: Framework Keywords: ICAT
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

When I log into the catalog (from catalog in the tool bar) with an invalid username/password. I get en error message saying "Error in execution of algorithm CatalogLogin:" rather than an appropriate response such as "Invalid username or password". Perhaps the message could indicated that a federal ID is needed as the user name.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to assigned

We need to avoid the use of terms like federal id or ucams /xcams as they are facility specific. Stick to username / password

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:8 Changed 7 years ago by Karl Palmen

  • type changed from enhancement to defect

comment:9 Changed 7 years ago by Karl Palmen

Also reported as #6440.

comment:10 Changed 7 years ago by Nick Draper

  • Keywords ICAT added
  • Summary changed from Incorrect login to Catalog does not show an appropriate response to ICAT: Incorrect login to Catalog does not show an appropriate response

comment:11 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:12 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:13 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:14 Changed 7 years ago by Nick Draper

  • Owner changed from Anyone to Jay Rainey
  • Milestone changed from Backlog to Release 3.0

comment:15 Changed 7 years ago by Jay Rainey

  • Status changed from new to verify
  • Resolution set to fixed

This ticket has been resolved in ticket #7639. However, I was unable to suppress the general error message created by the algorithm class (Error in execution of algorithm CatalogLogin:), and have added a more helpful and user friendly message.

To verify this is true:

  1. Open Mantid
  2. Goto Catalog -> Login
  3. Input invalid username, password, or both (same error message returned for all).
  4. Error message returned: Username or password supplied is invalid.

Similar functionality has been implemented for ICat4 and for the logout routine in ICat3 and 4. To test this view the comments on #7639, specifcally ​comment:25. To code review see ​comment:30 and ​31

Last edited 7 years ago by Jay Rainey (previous) (diff)

comment:16 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:17 Changed 7 years ago by Karl Palmen

I test using master.

comment:18 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4666

Note: See TracTickets for help on using tickets.