Ticket #3854 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Check that RunNumber of peak matches RunNumber of workspace in PeakIntegration

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

ISAW peak files contain peaks from multiple runs. Should only integrate peaks that are in workspace.

Change History

comment:1 Changed 9 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Vickie Lynch

In [14914]:

Refs #3854 Only integrate peaks with same run number as workspace

comment:3 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:5 Changed 9 years ago by Wenduo Zhou

  • Status changed from verifying to verify
  • Tester Wenduo Zhou deleted

comment:6 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to reopened
  • Resolution fixed deleted 
LoadEventNexus(Filename=r'/home/8oz/data/TOPAZ_4697_event.nxs',OutputWorkspace='4697')
Rebin(InputWorkspace='4697',OutputWorkspace='4697',Params='0,100,16000')
LoadIsawPeaks(Filename=r'/home/8oz/Code/Mantid/Test/AutoTestData/TOPAZ_3007.peaks',OutputWorkspace='peaks')

And then run PeakIntegration with the peaks and 4697 workspaces. There are no peaks with the right run number so the algorithm tries to start at peak -1, which segfaults.

As a more general note, your code relies on the PeaksWorkspace to be sorted by run number, which is not guaranteed. It might also be nice to have an option to NOT restrict by run number; maybe two runs were at the same goniometer setting but different temperature and you want to compare.

comment:8 Changed 9 years ago by Nick Draper

Please fix the seg fault for this release, and then create a seperate ticket in the next iteration for the more widespread code improvements.

comment:9 Changed 9 years ago by Vickie Lynch

  • Status changed from reopened to accepted

comment:10 Changed 9 years ago by Vickie Lynch

Refs #3854 check for no matching RunNumbers

Changeset: 55d1e0827925f1290d1f9ae60bacc6c8d87dfd88

comment:11 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 9 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester changed from Janik Zikovsky to Karl Palmen

comment:13 Changed 9 years ago by Karl Palmen

  • Status changed from verifying to verify
  • Tester Karl Palmen deleted

Cannot obtain workspaces suitable for testing (Topaz).

comment:14 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:15 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

No segfault! Made ticket #4496 for other minor changes.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4701

Note: See TracTickets for help on using tickets.