Ticket #3873 (closed: worksforme)

Opened 9 years ago

Last modified 5 years ago

Opencascade bug: returns a bad pointer instead of raising error

Reported by: Roman Tolchenov Owned by: Russell Taylor
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description


Change History

comment:1 Changed 9 years ago by Roman Tolchenov

It seems that OCC handles poorly non-orthogonal infinite planes

comment:2 Changed 9 years ago by Roman Tolchenov

Now I am not sure about the previous remark but OCC certainly may return a garbage pointer if things go wrong. Also there is a problem with Mantid calculating bounding boxes for cuboids made up of non-axis aligned planes.

comment:3 Changed 9 years ago by Roman Tolchenov

In [15049]:

Limit objects bounding box to 200 units. Test for zero normal in planes. re #3873

comment:4 Changed 9 years ago by Anders Markvardsen

Just a reminder (for me) that when time I will add code which can be activated for debugging, or other reason perhaps later, that write out transformed xml code when using <combine-into-one-shape> element in IDF. Roman indicates that this may help understanding Opencascade bug.

comment:5 Changed 9 years ago by Anders Markvardsen

Added method to allow saving of IDF DOM tree. Re #3873.

Changeset: e847d1c6308142e58ab6fa9453d8ce6926420a34

comment:6 Changed 9 years ago by Anders Markvardsen

Minor change to comment. Re #3873

Changeset: 894f7e84fe94c79c59552c2430a248f553c1a51e

comment:7 Changed 9 years ago by Anders Markvardsen

Added method to allow saving of IDF DOM tree. Re #3873.

Changeset: e847d1c6308142e58ab6fa9453d8ce6926420a34

comment:8 Changed 9 years ago by Anders Markvardsen

Minor change to comment. Re #3873

Changeset: 894f7e84fe94c79c59552c2430a248f553c1a51e

comment:9 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:10 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:11 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:12 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:13 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:14 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:15 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:16 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:17 Changed 7 years ago by Russell Taylor

  • Status changed from new to infoneeded

Is this still relevant?

comment:18 Changed 7 years ago by Roman Tolchenov

We haven't had any troubles since the last commit. I guess it could be closed.

comment:19 Changed 7 years ago by Russell Taylor

  • Status changed from infoneeded to verify
  • Owner changed from Roman Tolchenov to Russell Taylor
  • Resolution set to worksforme
  • Milestone changed from Backlog to Release 3.2

The commits here have been in Mantid since version 2.0.

comment:20 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:21 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

Seems like a crusty old ticket that should have been closed as "invalid."

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4720

Note: See TracTickets for help on using tickets.