Ticket #3878 (closed)

Opened 9 years ago

Last modified 5 years ago

Partial loading of spectra for LoadEventNexus

Reported by: Martyn Gigg Owned by: Raquel Alvarez Banos
Priority: critical Milestone: Release 3.3
Component: Framework Keywords: NewStarter
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Jon Taylor has requested that LoadEventNexus be able to support partial loading in a similar manner to the other load algorithms where you can supply a range/list of spectra to load.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to assigned

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:8 Changed 7 years ago by Nick Draper

  • Priority changed from major to critical

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:10 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:11 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after R2.6

comment:12 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:13 Changed 6 years ago by Nick Draper

  • Keywords NewStarter added

This is supported for ISIS histogram but not event nexus files.

Check you suggested changes with a senior developer

comment:14 Changed 6 years ago by Nick Draper

  • Owner changed from Anyone to Raquel Alvarez Banos
  • Milestone changed from Backlog to Release 3.3

comment:15 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

LoadEventNexus Re #3878

Changeset: 598983436344aa11324b61234f88a9e367def690

comment:16 Changed 6 years ago by Raquel Alvarez Banos

LoadEventNexusTest Re #3878

Changeset: e24da76ae1d7ab708063a2a4586d8575bc7f029c

comment:17 Changed 6 years ago by Raquel Alvarez Banos

comment clarified RE #3878

Changeset: 409e963a1602d1e0eb2864ba45f4211c23d2f654

comment:18 Changed 6 years ago by Raquel Alvarez Banos

Added missing setSpectrumNumber, updated method descriptions Re #3878

Changeset: 23a2ef27cf8735fffdd3671ad229ba3ea57afe8e

comment:19 Changed 6 years ago by Raquel Alvarez Banos

LoadEventNexus test updated Re #3878

Changeset: 327d989b18ad30b97a59a1ac1711a49e9085277f

comment:20 Changed 6 years ago by Raquel Alvarez Banos

partial spectra loading in LoadEventNexus Re #3878

Changeset: fe546e5affcf34d3a8f4fd23cdc966d3575d9668

comment:21 Changed 6 years ago by Raquel Alvarez Banos

test partial spectra loading in LoadEventNexus Re #3878

Changeset: d752c06a0ef063f76eeb3f2566f5d6ef280b5d6c

comment:22 Changed 6 years ago by Raquel Alvarez Banos

partial spectra loading in LoadEventNexus Re #3878

Changeset: 49d4dced52715700c9cf027b4314d416fc002c1b

comment:23 Changed 6 years ago by Raquel Alvarez Banos

formatting LoadEventNexus Re #3878

Changeset: d206e01224d3099b36652d81e8b9f870cfc9ecc4

comment:24 Changed 6 years ago by Raquel Alvarez Banos

new formatting LoadEventNexus Re #3878

Changeset: 0cf537dc76342ee15e81acf57f498ab06e186e8b

comment:25 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed

The code described in the ticket should work now. LoadEventNexus includes three additional fields to select the spectra to load:

  • SpectrumMin: the minimum spectrum to load
  • SpectrumMax: the maximum spectrum to load
  • SpectrumList: alternatively, the user can supply a list of spectra to load.

To test:

  • Load an Event Nexus File (for example CNCS_7860_event.nxs)
  • Select the desired spectra
  • Check that the number of histograms in the workspace matches the number of selected spectra
Last edited 6 years ago by Raquel Alvarez Banos (previous) (diff)

comment:26 Changed 6 years ago by Raquel Alvarez Banos

Merge remote-tracking branch 'origin/master' into

feature/3878_partial_spectra_loading_event_nexus

Conflicts:

Code/Mantid/Framework/DataHandling/src/LoadEventNexus.cpp

Refs #3878

Changeset: a09189e18ee412ba022e3ce8dfaee822bc4e73d3

comment:27 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:28 Changed 6 years ago by Martyn Gigg

There are a couple of Linux compiler warnings: ​http://builds.mantidproject.org/view/Develop%20Builds/job/develop_clean/label=ubuntu-14.04-build/416/warnings19Result/ to take care of.

comment:29 Changed 6 years ago by Raquel Alvarez Banos

LoadEventNexusTest Linux compiler warnings fixed Re #3878

Changeset: dbd38823eaa36629b53387cef82683e40a08bfd9

comment:30 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Hi Raquel,

Tested in for the systemtest dataset systemtests\Data\SANS2D\SANS2D00022023.nxs

Your code worked for the case of selecting spec min/max 1000/1001, and gave a useful error message when selected 10000000/10000001.

But when selecting min/max = 1/4 then I get the get the message:

{ Error in execution of algorithm LoadEventNexus: vector<T> too long Error in execution of algorithm Load: vector<T> too long }

comment:31 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from reopened to inprogress

vector<T> too long error fixed Re #3878

Changeset: 1ecf8470095ab84e2080f40b87a925a5302dcf69

comment:32 Changed 6 years ago by Anders Markvardsen

  • Status changed from inprogress to closed

Merge remote-tracking branch 'origin/feature/3878_partial_spectra_loading_event_nexus'

Full changeset: ​8f3686d8aa3eb8c9cdab27d3819d252af2a55276

comment:33 Changed 6 years ago by Anders Markvardsen

tested with sns and isis data. partial loading now enabled. unit test added

comment:34 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4725

Note: See TracTickets for help on using tickets.