Ticket #3907 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Refactor IMDWorkspace

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

  • Remove methods on IMDWorkspace assuming regular gridding
  • Remove old MDWorkspace classes

Attachments

MDWorkspaceBrief.png​ (15.2 KB) - added by Owen Arnold 9 years ago.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

In [15087]:

Refs #3907: Setting the ground work for refactoring IMDWorkspace

comment:3 Changed 9 years ago by Janik Zikovsky

In [15088]:

Refs #3907: Win build fix for precompiled headers?

comment:4 Changed 9 years ago by Janik Zikovsky

In [15093]:

Refs #3907: Cleanup of IMDDimension and MDGeometryOld

comment:5 Changed 9 years ago by Janik Zikovsky

In [15094]:

Refs #3907: Win precompiled headers again

comment:6 Changed 9 years ago by Janik Zikovsky

In [15096]:

Refs #3907: Removed IMDWorkspaceProxy

comment:7 Changed 9 years ago by Janik Zikovsky

In [15109]:

Refs #3907: Removed some methods from IMDWorkspace.

comment:8 Changed 9 years ago by Janik Zikovsky

In [15141]:

Refs #3907: Renamed MDDataObjects inc/ folder

comment:9 Changed 9 years ago by Janik Zikovsky

In [15145]:

Refs #3907: Try to fix the precompiled headers

comment:10 Changed 9 years ago by Janik Zikovsky

In [15159]:

Refs #3907: Removed MDFitWorkspace and commented out CreateMDFitWorkspace as they are not needed and will be replaced by MDHistoWorkspace as needed.

comment:11 Changed 9 years ago by Janik Zikovsky

In [15162]:

Refs #3907: Removed MDCell, MDPoint, Coordinate, SignalAggregate. Commented out parts of SimulateMDDTest which will need to be reworked a bit.

comment:12 Changed 9 years ago by Janik Zikovsky

In [15170]:

Refs #3907: Removed MDDataObjects subproject as it was empty.

comment:13 Changed 9 years ago by Janik Zikovsky

In [15172]:

Refs #3907: Made MDEventWorkspace inherit from IMDWorkspace. Added tests to MDGeometryTest. Clarified the getDimension() calls, which were ambiguous.

comment:14 Changed 9 years ago by Janik Zikovsky

In [15173]:

Refs #3907: Fix build.

comment:15 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:16 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

Changed 9 years ago by Owen Arnold

comment:17 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Refactoring has been based around the attached UML. This diagram was generated prior to any work on the ticket, so there may be some minor changes.

Everything works as expected. Most importantly the following aspects of the design have been achieved.

  • All MD related workspaces are IMDWorkspaces
  • IMDWorkpace provides createIterator method, which can be overridden on subclasses

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4754

Note: See TracTickets for help on using tickets.