Ticket #391 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Remove SpectraDetectorMap dependency on its containing workspace

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 15
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

There's a problem with SpectraDetectorMap in that it holds a pointer to the workspace it belongs to, but in theory a map can be shared between workspaces. I'm going to move certain methods up into MatrixWorkspace to resolve this.

Change History

comment:1 Changed 12 years ago by Russell Taylor

  • Status changed from new to assigned
  • type changed from enhancement to defect

comment:2 Changed 12 years ago by Russell Taylor

(In [1901]) Removed dependency on containing workspace from SpectraDetectorMap. This entailed moving getDetector method up into MatrixWorkspace. Also, it now takes a workspace index instead of a spectrum number, meaning that algorithms typically (though not always) need not know about either the spectraMap or the spectra numbers (from the axis). Re #391.

comment:3 Changed 12 years ago by Russell Taylor

(In [1902]) Fix tests, I think. Re #391.

comment:4 Changed 12 years ago by Russell Taylor

(In [1903]) Try again. Re #391.

comment:5 Changed 12 years ago by Russell Taylor

(In [1904]) Change reference to getDetector in MantidPlot. Re #391.

comment:6 Changed 12 years ago by Russell Taylor

(In [1905]) Small tidy up. Re #391.

comment:7 Changed 12 years ago by Russell Taylor

(In [1916]) Further improvements to SpectraDetectorMap. It's now automatically copied if necessary. Re #391.

comment:8 Changed 12 years ago by Russell Taylor

(In [1917]) Update SpectraDetectorMap call. Re #391.

comment:9 Changed 12 years ago by Russell Taylor

  • Status changed from assigned to closed
  • Resolution set to fixed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1239

Note: See TracTickets for help on using tickets.