Ticket #3946 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Check new AzizAnalysis expected output System Test

Reported by: Owen Arnold Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: nick.draper@… Blocked By: #3945
Blocking: Tester: Michael Reuter

Description

We will be updating the system test expected ouput. Need to check that this has been done correctly. System test was failing due to a small delta in the actual data generated (~1E-5) after it was updated by Martyn.

Change History

comment:1 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Martyn Gigg

Refs #3946. Something seem to go wrong with the reference result. This one should be correct.

Changeset: 97c8d2fbc76439bb2da1d90b76f52f19e1fd7d2f

comment:3 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

Turns out that there was a minor difference in how phi wwas calculated on some platforms due to a sum not quite being zero when it should have been due to floating point error.

comment:5 Changed 9 years ago by Martyn Gigg

Refs #3946. Minor correction to getPhi method that corrects the average position when the sum should have been zero but it was off due to floating point precision.

Changeset: 37775d0ee8fb1c7806344053b9b75f2a0a016e8a

comment:6 Changed 9 years ago by Martyn Gigg

Minor update to ref file. Refs #3946

Changeset: d43e405329046f2429d35bcec78dcac963c47c1f

comment:7 Changed 9 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:8 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:10 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

Once I was able to track down the new name for the test, it seems to run OK on my system. I also searched the system test emails for failures and I can't find one attributed to HRPDPowderDiffraction after the fix was made.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4793

Note: See TracTickets for help on using tickets.