Ticket #3951 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

EQSANS: Refactor normalisation step as workflow algo

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Get rid of the Normalize reduction step in sns_reduction_steps.py and replace it by a WorkflowAlgorithm

Change History

comment:1 Changed 9 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Mathieu Doucet

In [15225]:

Moved normalization to workflow algorithm. Re #3951

comment:3 Changed 9 years ago by Mathieu Doucet

In [15249]:

removing old code. Re #3951

comment:4 Changed 9 years ago by Mathieu Doucet

In [15252]:

clean up Re #3951

comment:5 Changed 9 years ago by Mathieu Doucet

In [15271]:

clean up Re #3951

comment:6 Changed 9 years ago by Mathieu Doucet

In [15299]:

Add TOF cuts to EQSANS load. Re #3951

comment:7 Changed 9 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:9 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Removed the sns_reduction_steps Normalize and added WorkflowAlgorithm EQSANSNormalise.

Minor comment (please bare in mind I know little about the oak ridge sans):

Since there is now a EQSANSNormalise I kind of expected to see equivalent ones for the HFIR instruments

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4798

Note: See TracTickets for help on using tickets.