Ticket #3952 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

LoadEventNeXus sets incorrect pulse times for ISIS event data

Reported by: Freddie Akeroyd Owned by: Freddie Akeroyd
Priority: critical Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

Absolute pulse times are read from the proton log, not the time arrays in NXevent_data. If the proton log is shorter than the event index array, incorrect values are assigned.

Change History

comment:1 Changed 9 years ago by Freddie Akeroyd

In [15232]:

  • Load ISIS frame by frame proton log and adjust for array length difference between this and event_index array
  • Increase log level from debug to warning for message about event/proton array length mismatch

Refs #3952

comment:2 Changed 9 years ago by Freddie Akeroyd

In [15253]:

Move code for ISIS proton log into LoadNexusLogs to (hopefully) allow filtering by microamps.
Refs #3952

comment:3 Changed 9 years ago by Freddie Akeroyd

In [15263]:

Allow either StartTime or StopTime relative times to be specified instead of requiring both. Refs #3952

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:9 Changed 8 years ago by Freddie Akeroyd

  • Status changed from new to accepted

comment:10 Changed 8 years ago by Freddie Akeroyd

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 8 years ago by Stuart Campbell

  • Milestone changed from Release 2.5 to Release 2.4

comment:12 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:13 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to closed

Since this was last modified 6 releases ago I'm going to cite the users as sufficient testing.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4799

Note: See TracTickets for help on using tickets.