Ticket #3957 (closed: fixed)
The Windows installer needs to clean up before running
Reported by: | Russell Taylor | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | major | Milestone: | Release 2.0 |
Component: | Tools | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Ronald Fowler |
Description
The MDDataObjects library was recently removed. However, if someone installs a new version over a previous one that had the library, the old shared library is not removed. This causes an error message when dllopen tried to load it.
This is not actually a functional problem, but we're likely to get a lot of comments about it.
Change History
comment:1 Changed 9 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Martyn Gigg
comment:2 Changed 9 years ago by Martyn Gigg
So it turns out this was due to the changes so that you can install the MSI without user privileges. The sketchy documentation around WIX didn't mention that if you change a per-machine (i.e. our old one) to a per-user (the new one with admin rights) then the per-user one can't remove an old one if it was installed per machine.
When I tested the removal functionality I must have inadvertantly tested it with removing another per-user one and it succeeds with that.
comment:3 Changed 9 years ago by Martyn Gigg
Refs #3957. Stop the Win installer overwriting an old one that it can't remove
Changeset: 54e4bcbac6f1e2a464435a44793cc3eee3a850e8
comment:4 Changed 9 years ago by Martyn Gigg
Refs #3957. Missed the important files it would seem.
Changeset: bd21bd0e8106664631314847a4639b3851512841
comment:5 Changed 9 years ago by Martyn Gigg
Refs #3957. Fix for WIXSDK in script variable.
Changeset: ea907f7ecdb26782428348e669491cd5a87435e3
comment:7 Changed 9 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:8 Changed 9 years ago by Martyn Gigg
Refs #3957. Stop the Win installer overwriting an old one that it can't remove
Changeset: 54e4bcbac6f1e2a464435a44793cc3eee3a850e8
comment:9 Changed 9 years ago by Martyn Gigg
Refs #3957. Missed the important files it would seem.
Changeset: bd21bd0e8106664631314847a4639b3851512841
comment:10 Changed 9 years ago by Martyn Gigg
Refs #3957. Fix for WIXSDK in script variable.
Changeset: ea907f7ecdb26782428348e669491cd5a87435e3
comment:11 Changed 9 years ago by Ronald Fowler
- Status changed from verify to verifying
- Tester set to Ronald Fowler
comment:12 Changed 9 years ago by Ronald Fowler
- Status changed from verifying to closed
The current Windows installer will refuse to remove the previous release of Mantid and requests the user to remove it through the control panel. This avoids any problem with MDDataObjects being left in place. If upgrading a recent version the installer does overwrite the existing install with no problems.
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4804