Ticket #4005 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Expose Split into and Split Threshold

Reported by: Owen Arnold Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.0
Component: VATES Keywords:
Cc: Pascal.Manuel@… Blocked By: #4043
Blocking: Tester: Owen Arnold

Description

The MD Workspace naturally bins/groups the data into a recursive box structure. Without generating histograms, it would be very useful to allow binning/rebinning on this structure by modifying the split threshold and split into parameters. This may form some kind of clone operation.

It may be best at this point to go ahead and utilise and inject a strategy to define how the binning should take place (i.e. constant signal to noise).

I'm happy to code this myself, so reasign back to me if required.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

Exposed in CreateMDWorkspace but we need to talk about how it can be integrated in other algorithms e.g. ConvertToDiffractionMD

comment:2 Changed 9 years ago by Owen Arnold

Maybe best to leave ConvertToDiffractionMD as it is because I know you did some work on tuning of these parameters. Utilising splitinto and splitthreshold should probably form another algorithm. The current use case is to tweak these parameters for visualisation.

comment:3 Changed 9 years ago by Owen Arnold

  • Component changed from Mantid to VATES

comment:4 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:5 Changed 9 years ago by Janik Zikovsky

  • Blocked By 4043 added

comment:6 Changed 9 years ago by Janik Zikovsky

Refs #4005: Started to split box controller settings so as to expose them more easily

Changeset: 9065a7041c0e10dc7bcc3420980ad4ee88b7190a

comment:7 Changed 9 years ago by Janik Zikovsky

Refs #4005: Exposed box controller settings to the ConvertToDiffractionMD algorithm.

Changeset: f353e0c821ecb39a5ea525bf8586c3dc21146556

comment:8 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Those parameters are now available to ConvertToDiffractionMDWorkspace. A more sophisticated BoxController can be a new ticket instead.

comment:9 Changed 9 years ago by Janik Zikovsky

Refs #4005: Started to split box controller settings so as to expose them more easily

Changeset: 9065a7041c0e10dc7bcc3420980ad4ee88b7190a

comment:10 Changed 9 years ago by Janik Zikovsky

Refs #4005: Exposed box controller settings to the ConvertToDiffractionMD algorithm.

Changeset: f353e0c821ecb39a5ea525bf8586c3dc21146556

comment:11 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:12 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Works! Nice approach via baseclass algorithm. Algorithms such as ConvertToDiffractionMDWorkspace are picking up these settings.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4852

Note: See TracTickets for help on using tickets.