Ticket #401 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Improve the perfomance of solid angle calculations

Reported by: Nick Draper Owned by: Ronald Fowler
Priority: major Milestone: Iteration 15
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

Use the triangulation to improve the accuarcy and performance

Change History

comment:1 Changed 12 years ago by Ronald Fowler

(In [1946]) Updated solid angle calculation using the surface triangulation. If the triangulation is good and the number of elements not too high this gives a better and faster estimate of the solid angle. Added unit tests. Re #401

comment:2 Changed 12 years ago by Ronald Fowler

(In [1951]) Fix to fall back to ray tracing solid angle if no triangulation found. Also fix to Nexus not to print error message if "units" attribute not present. Re #401

comment:3 Changed 12 years ago by Ronald Fowler

(In [1953]) Another minor fix for the fix, for Linux in the header file Re #401

comment:4 Changed 12 years ago by Ronald Fowler

(In [1957]) Fix to not call glIsList when displaylist is 0. re #401

comment:5 Changed 12 years ago by Ronald Fowler

(In [1958]) Updated solid angle calculation for cuboids (marked as such in XML) to use faster and more accurate triangle method. Also updated unit test solidAngle to expect new values. For the relatively high aspect ratio cuboids in the example, about 10 wide to 1 long, the ray tracing method is only accurate to 15% which is not good. Re #401

comment:6 Changed 12 years ago by Martyn Gigg

(In [1959]) Small fix to template arguments so that Mantid will compile on Linux. Re #401

comment:7 Changed 12 years ago by Sri Nagella

(In [1967]) refs #401 Fixed Object solid angle calling initDraw

comment:8 Changed 12 years ago by Nick Draper

  • Status changed from new to closed
  • Resolution set to fixed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 1249

Note: See TracTickets for help on using tickets.