Ticket #4020 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

broken display of log files

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description

This must have been broken very recently, since on James Lord computer the other day this worked.

1) load e.g. any of the HIFI data from
isis\inst$\NDXHIFI\Instrument\data\cycle_11_3 say HIFI00029177 or HIFI00025177 2) rigth click over created workspace and chose Sample log.. 3) select e.g. Temp_Sample and click on 'Import selected log'

This produces the following error:

Unexpected exception: Run::startTime() - No start time has been set for this run. Continue working.

However the run_start Run property has been set correctly so Mantid should know the start time for this run

Change History

comment:1 Changed 9 years ago by Karl Palmen

The problem does occur with the Mantiplot I run from Visual C++, but not the version 1.30.14743, which I run as a stand alone application.

comment:2 Changed 9 years ago by Karl Palmen

In commit 7dc838f26b242a38d76dc56323253af538ae8801 forgot Re in reference to this ticket.

comment:3 Changed 9 years ago by Karl Palmen

Use run_start instead of start_time for re #4020.

Changeset: 8052f8a55818f81cc4271c4db758b83d490d6272

comment:4 Changed 9 years ago by Karl Palmen

In making the change 8052f8a55818f81cc4271c4db758b83d490d6272 to fix this problem I modified and possibly reversed a recent change by Martyn Gigg. We will need to talk about to ensure a complete fix before counting this as resolved.

comment:5 Changed 9 years ago by Karl Palmen

For logs as in re #4020 use start_time if found else use run_start, likewise with end_time and run_end.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ded3815249370a3288be1c2c2be7f48f7e835afb

comment:6 Changed 9 years ago by Karl Palmen

  • Status changed from new to accepted

comment:7 Changed 9 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

Fix accepted as valid, therefore issue is resolved.

comment:8 Changed 9 years ago by Karl Palmen

Use run_start instead of start_time for re #4020.

Changeset: 8052f8a55818f81cc4271c4db758b83d490d6272

comment:9 Changed 9 years ago by Karl Palmen

For logs as in re #4020 use start_time if found else use run_start, likewise with end_time and run_end.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ded3815249370a3288be1c2c2be7f48f7e835afb

comment:10 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:11 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

This now works

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4867

Note: See TracTickets for help on using tickets.