Ticket #4024 (closed: fixed)
When NeXus 4.3.0 is released, remove the custom nexus C++ api from mantid
| Reported by: | Janik Zikovsky | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description
Try this in a branch to make sure it works.
Change History
comment:3 Changed 9 years ago by Janik Zikovsky
Refs #4024 progress towards removing C++ nexus API
Changeset: 33b40c25cff88099ebcee56a94219da775d04c8a
comment:4 Changed 9 years ago by Janik Zikovsky
Refs #4024 moving out Nexus CPP from mantid. Tests don't pass yet
Changeset: f6626aa0a21b0b5abbe19a6a37920e7d92bb3a25
comment:5 Changed 9 years ago by Janik Zikovsky
Refs #4024 trying to fix this nexus bug
Changeset: 4248f3decf0dcf35dd1fd959a42ed47ec154fb74
comment:6 Changed 9 years ago by Janik Zikovsky
Refs #4024 progress towards removing C++ nexus API
Changeset: aba9d7f53352dc09555aece2c236e1d1df337b94
comment:7 Changed 9 years ago by Janik Zikovsky
Refs #4024 moving out Nexus CPP from mantid. Tests don't pass yet
Changeset: e9f63cedd0c84f4bb8e16076182ae3d584cdfb77
comment:8 Changed 9 years ago by Janik Zikovsky
Refs #4024 trying to fix this nexus bug
Changeset: b84e2a4ab5c8c6c29756601f2d88c282831c20be
comment:9 Changed 9 years ago by Janik Zikovsky
Refs #4024 updating the branch
Changeset: 08366aee456f4318d58abd858e90f2cfb90390af
comment:10 Changed 9 years ago by Janik Zikovsky
Refs #4024 progress towards removing C++ nexus API
Changeset: 4ff4958e70ae55f8a98ce808aeceb90837ad1809
comment:11 Changed 9 years ago by Janik Zikovsky
Refs #4024 moving out Nexus CPP from mantid. Tests don't pass yet
Changeset: 53cda405f4c4feae66e5f095fdd6f7ad527733fd
comment:12 Changed 9 years ago by Janik Zikovsky
Refs #4024 trying to fix this nexus bug
Changeset: 6ba71bc672f7b5d081aec745418eecf71c9c46d3
comment:13 Changed 9 years ago by Janik Zikovsky
Refs #4024 progress towards removing C++ nexus API
Changeset: 5d8840bc661c158f2b9e74d0062a683e454045f3
comment:14 Changed 9 years ago by Janik Zikovsky
Refs #4024 moving out Nexus CPP from mantid. Tests don't pass yet
Changeset: 76bc44322b198500833cc3300632714a2a56bdcd
comment:15 Changed 9 years ago by Janik Zikovsky
Refs #4024 trying to merge
Changeset: ef4ecea5e9e7a2f4638f20d5e5f617422e2f89d3
comment:16 Changed 9 years ago by Janik Zikovsky
Refs #4024 merging master
Changeset: 3ccff226edc8365b7141f8b1e12d7cc27125f27b
comment:17 Changed 9 years ago by Janik Zikovsky
Refs #4024 working on nexus bug
got it narrowed down to SaveMD(MakeFileBacked=1)
Changeset: f5ae30513d996f5ebe3f10f8c8624014e4686afa
comment:18 Changed 9 years ago by Janik Zikovsky
Refs #4024, hopeful nexus fix
removed MakeFileBacked option from SaveMD as it was causing the problem.
Changeset: f1e4f54e531a412e2bcb010d57a8771feabf8218
comment:19 Changed 9 years ago by Janik Zikovsky
Refs #4024 checkpoint my test fix attempts
Changeset: 95a82a3b69891c20e05e2e5efd6b813a18341c75
comment:20 Changed 9 years ago by Janik Zikovsky
REfs #4024 another checkpoint
MD tests pass thank god with latest nexus version
Changeset: 619fa5df2bf3fb3f91805f6764bc9f7e08c31afc
comment:21 Changed 9 years ago by Janik Zikovsky
Refs #4024 merging changes for Nexus 4.3.0
... from branch4024 to master.
Changeset: 502a7ec1324911306213bb9b64e28dde4e09c8ed
comment:22 Changed 9 years ago by Janik Zikovsky
Refs #4024 fixes for windows nexus 4.3.0
Changeset: 03a5a4da0cad5164123a5acdd7c74ff37bb3d575
comment:23 Changed 9 years ago by Janik Zikovsky
Refs #4024 try to fix finding library for other platforms
Changeset: d457998f0f58e930610a81a8dad3f71bf8a9c14e
comment:24 Changed 9 years ago by Janik Zikovsky
Refs #4024 : un-merging I hope
Changeset: 9e3c896647f6ce48e964bb41c8e9d38a3558ca47
comment:25 Changed 9 years ago by Janik Zikovsky
Refs #4024 nexus fix for Natty maybe
Changeset: d198cdf3a02a5434754ee26051d2b6f1ae0c0d5c
comment:26 Changed 9 years ago by Janik Zikovsky
Refs #4024: trying nexus 4.3.0 again.
Same as last time, will let the windows builds run to get a list of failing tests on the ISIS build servers; see if it is any different than the SNS build servers.
Changeset: 6eb784322cd3388e7b902161454bbdc9ff31d8c7
comment:27 Changed 9 years ago by Janik Zikovsky
Refs #4024: going back to in-Mantid NexusCPP bindings.
This reverts commit 6eb784322cd3388e7b902161454bbdc9ff31d8c7.
Changeset: f4c867fdc4e9226c9fbb6f1be39e564b5a81c411
comment:28 Changed 9 years ago by Janik Zikovsky
Refs #4024: trying latest Nexus build from Freddie
This reverts commit f4c867fdc4e9226c9fbb6f1be39e564b5a81c411.
Conflicts:
Code/Mantid/Framework/NexusCPP/inc/MantidNexusCPP/NeXusFile.hpp
Changeset: 34d300f434ca3f111e61b34d61bb4958bcd55c2d
comment:29 Changed 9 years ago by Janik Zikovsky
Refs #4024: going back to old Nexus (again!)
This reverts commit 34d300f434ca3f111e61b34d61bb4958bcd55c2d.
Changeset: 5f2e4cc188a16e6a6a56a1682289f140a1ea3028
comment:30 Changed 9 years ago by Janik Zikovsky
Refs #4024: freddie's latest nexus CPP libraries seem to work.
Changeset: 75b55826daaa509a7f96d53f3bb94bda30992667
comment:31 Changed 9 years ago by Janik Zikovsky
Refs #4024: latest Nexus windows binary
This reverts commit 5f2e4cc188a16e6a6a56a1682289f140a1ea3028.
Changeset: 2d640ffb0d0591bd10ef0ee680339836b1585e63
comment:32 Changed 9 years ago by Martyn Gigg
Refs #4024. Attempt to fix Win32 build
Changeset: 87d8cc4d3b4f6d9774857bc7cfddf804e80a5069
comment:33 Changed 9 years ago by Martyn Gigg
Refs #4024. Further name clash removal on Win32
Changeset: a89112d6d5c6128058bd7263fad427bd79ed6c34
comment:34 Changed 9 years ago by Martyn Gigg
Refs #4024. Should fix the last of the name ambiguity on win32
Changeset: 5798002596bb406b92c0f3ee13b0be40043f434b
comment:35 Changed 9 years ago by Janik Zikovsky
Refs #4024: revert yet again to 4.2.1 nexus
This reverts commit 2d640ffb0d0591bd10ef0ee680339836b1585e63.
Changeset: a451aaae78c7c45701d646599441d38bf79a229b
comment:36 Changed 9 years ago by Martyn Gigg
Revert "Refs #4024: freddie's latest nexus CPP libraries seem to work."
This reverts commit 75b55826daaa509a7f96d53f3bb94bda30992667. The libraries don't work properly in Debug and are linked to MSVC80 rather than MSVC100
Changeset: 9910f43c3ee61777a899a6ac9b23fdb12e05dba5
comment:37 Changed 9 years ago by Freddie Akeroyd
Commit win64 NeXus libraries - previous libNeXus-0 was accidentally linked against debug MSVCR100D.DLL Refs #4024
Changeset: fab9dbdc767f23eaf2adf84f81b8bfb04c5c6cf3
comment:38 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:39 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:40 Changed 8 years ago by Janik Zikovsky
- Owner changed from Janik Zikovsky to Anyone
- Status changed from accepted to assigned
comment:41 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:42 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:43 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:44 Changed 8 years ago by Peter Peterson
- Owner changed from Anyone to Peter Peterson
- Status changed from assigned to accepted
comment:45 Changed 8 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
This was finished off as part of #6518.
comment:46 Changed 8 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:47 Changed 8 years ago by Martyn Gigg
- Status changed from verifying to closed
Verified that MantidNexusCPP is no longer around and everything is using the official NeXus C++ API.
comment:48 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4871
Tobias.Richter@ diamond . ac . uk is the person who handled NX_UNLIMITED and my contact if I find it doesn't work.