Ticket #4028 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

PlusMDTest file+file test fails on windows

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description


Change History

comment:1 Changed 9 years ago by Janik Zikovsky

Refs #4028 fix PlusMD test on Windows

Missed a virtual destructor, causing the MDEW to note delete so the file was still open.

Changeset: b800e69091c1f72a880abe78f01c0d960f9e1996

Last edited 9 years ago by Janik Zikovsky (previous) (diff)

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Janik Zikovsky

Note to testers: There were three tests, test_file_plus_file_*, in PlusMDTest that would fail.

It would be good to test if files are closed properly. E.g. Save a MD workspace to a file (and make file backed). Delete that workspace. Then make a new file-backed one on the same file - does it work?

comment:4 Changed 9 years ago by Janik Zikovsky

Refs #4028 this fixes it

Changeset: d10b11b8b153f9ad6c7af8b4334d1c172ae3be9d

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Janik Zikovsky

Refs #4028 fix PlusMD test on Windows

Changeset: b800e69091c1f72a880abe78f01c0d960f9e1996

comment:7 Changed 9 years ago by Janik Zikovsky

Refs #4028 this fixes it

Changeset: d10b11b8b153f9ad6c7af8b4334d1c172ae3be9d

comment:8 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:9 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

By following the prescription above, even with a few variations, I was unable to get any errors. I've also run the PlusMD test a number of times on with no issues. I tested it all on Windows.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4875

Note: See TracTickets for help on using tickets.