Ticket #4041 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

ORNL SANS: move beam finding to workflow alg

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description

Move beam finding to workflow alg. Write beam center to reduction table.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:3 Changed 8 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:4 Changed 8 years ago by Mathieu Doucet

Re #4041 Create beam finder workflow alg for SANS

Changeset: d812dfe46451a20c78f92414815bda8f4d83a23e

comment:5 Changed 8 years ago by Mathieu Doucet

Re #4041 Fixed issue with use as child alg

Changeset: 292947a0eaea2185ad0279d9d60a8025ff70eb87

comment:6 Changed 8 years ago by Mathieu Doucet

Re #4041 streamline beam finding workflow alg

Changeset: 6405b7171a8f240e41cfa8f4bfd9c5a626f87480

comment:7 Changed 8 years ago by Mathieu Doucet

Re #4041 Preparing for beam finder workflow alg

Changeset: 9e48ba758ddfdfbc29ae9fa1f87bcbe4bbcbe07b

comment:8 Changed 8 years ago by Mathieu Doucet

Re #4041 Tweaking monitor options

Changeset: b024d748ab89ff6fc94d25026879c40242c90fbc

comment:9 Changed 8 years ago by Mathieu Doucet

Re #4041 Switch to workflow algorithm

Changeset: 4a09f9da0022cbb8c958ff9b180c1ec503cfa4ac

comment:10 Changed 8 years ago by Mathieu Doucet

Re #4041 Getting rid of python code

Changeset: a834c0930d8ae3221d18a2b54eef671340534ed7

comment:11 Changed 8 years ago by Mathieu Doucet

Re #4041 Fixing beam center from config file

Changeset: ee3af423d2ffc6aa4423883af03206272f079ecb

comment:12 Changed 8 years ago by Mathieu Doucet

Re #4041 Getting rid of python code

Changeset: a834c0930d8ae3221d18a2b54eef671340534ed7

comment:13 Changed 8 years ago by Mathieu Doucet

Re #4041 Fixing beam center from config file

Changeset: ee3af423d2ffc6aa4423883af03206272f079ecb

comment:14 Changed 8 years ago by Mathieu Doucet

Re #4041 Fixing beam center from config file

Changeset: ee3af423d2ffc6aa4423883af03206272f079ecb

comment:15 Changed 8 years ago by Mathieu Doucet

Re #4041 Fixing beam center from config file

Changeset: ee3af423d2ffc6aa4423883af03206272f079ecb

comment:16 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:17 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

moved to Release 2.4

comment:18 Changed 8 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

To test: start the HFIR reduction UI and pick a file to compute the beam center position with. Then under tools, select the option to use the python API 2. This will force the reduction to use the beam center workflow algorithm.

comment:19 Changed 8 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:20 Changed 8 years ago by Alex Buts

  • Status changed from verifying to closed

Tested formally. It seems the suggested test procedure works and produces some nice graphs. There is also different roots with selected API 2 and without it selected. The old interface plots nice graph but the new one request you to plot this graph from the workspace manually.

Can not identify if it indeed uses beam centre workfolow algorithm, but according to code it should.

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4888

Note: See TracTickets for help on using tickets.