Ticket #4051 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Amend LoadEventPreNexus so that it's possible to load a 'chunk'

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: zikovskyjl@…, pf9@… Blocked By:
Blocking: Tester: Wenduo Zhou

Description

E.g. 1/10, 2/10, etc. Probably via adding two properties "ChunkNumber" & "TotalChunks". Doing it this way means all the logic of working out how many events the file contains etc will be within the algorithm. (I'm open to suggestion for better names or a better way).

As part of this, I'll ditch the "NumberOfEvents" property (it doesn't work right now anyway).

Change History

comment:1 Changed 9 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Russell Taylor

BinaryFile: Make relatively expensive getFileSize() method private

...and replace external calls to it with ones to the method that returns the cached result - getNumElements(). Re #4051.

Changeset: d82995dd74fc4fb7d90bced4004c106178dfc3ba

comment:3 Changed 9 years ago by Russell Taylor

Add the ability to 'chunk' loading of prenexus files. Re #4051.

Two new properties added: ChunkNumber & TotalChunks. NumberOfEvents property removed (it wasn't working anyway).

Changeset: 0378871cdae8a17dbcf370098e03ef4f67bbb28c

comment:4 Changed 9 years ago by Russell Taylor

BinaryFile: Make relatively expensive getFileSize() method private

...and replace external calls to it with ones to the method that returns the cached result - getNumElements(). Re #4051.

Changeset: d82995dd74fc4fb7d90bced4004c106178dfc3ba

comment:5 Changed 9 years ago by Russell Taylor

Add the ability to 'chunk' loading of prenexus files. Re #4051.

Two new properties added: ChunkNumber & TotalChunks. NumberOfEvents property removed (it wasn't working anyway).

Changeset: 0378871cdae8a17dbcf370098e03ef4f67bbb28c

comment:6 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

Done. No logic in here to do any kind of auto-determination of a sensible number of chunks to use (i.e. to avoid swap) - this was written with the cluster in mind, where memory isn't a problem. That should be a separate algorithm if needed.

comment:7 Changed 9 years ago by Wenduo Zhou

wiki needs to be updated.

comment:8 Changed 9 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:9 Changed 9 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:10 Changed 9 years ago by Russell Taylor

Add wiki comments. Re #4051.

Though I added them by hand to the wiki because wiki_maker doesn't work with python 2.6

Changeset: 8aca05bbe73e17ac4743ba1483e2da5f9b5b793d

comment:11 Changed 9 years ago by Russell Taylor

Wiki is up to date now.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4898

Note: See TracTickets for help on using tickets.