Ticket #405 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Marking detectors dead affects shared instrument.

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Iteration 16
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

When a detector is masked using the MarkDeadDetectors algorithm this sets a 'dead' flag within the Instrument object itself. This is potentially shared among workspaces and would even be loaded in as the instrument for a newly loaded raw file. This behaviour is probably OK in the majority of cases where the same detectors are always masked out, but there could be situations (e.g. debugging) where it isn't what's wanted.

Change History

comment:1 Changed 12 years ago by Russell Taylor

  • Owner set to Russell Taylor

comment:2 Changed 12 years ago by Russell Taylor

  • Status changed from new to assigned

comment:3 Changed 12 years ago by Russell Taylor

(In [2083]) Terminology change: We no longer mark detectors as dead, rather we mask them. This masking is lifted into the parameterised instrument from the base instrument: previously, masking a detector was a one way street until Mantid is restarted for all workspaces using that instrument (even freshly loaded ones). Re #405.

comment:4 Changed 12 years ago by Russell Taylor

(In [2084]) Oops. Re #405.

comment:5 Changed 12 years ago by Russell Taylor

(In [2088]) Fix incorrect cast in MoveInstrumentComponent. Recommended text of the day: Effective C++ Item 39 :) Re #405.

comment:6 Changed 12 years ago by Russell Taylor

  • Status changed from assigned to closed
  • Resolution set to fixed

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 1253

Note: See TracTickets for help on using tickets.