Ticket #4063 (closed: invalid)

Opened 9 years ago

Last modified 5 years ago

SANS: make ISISReducer and SANSReducer same attributes where possible

Reported by: Anders Markvardsen Owned by: Gesner Passos
Priority: trivial Milestone: Release 3.2
Component: SANS Keywords:
Cc: doucetm@… Blocked By:
Blocking: Tester: Peter Parker

Description (last modified by Anders Markvardsen) (diff)

Confusingly the ISISReducer currently use different attributes to store same information. For instance SANSReducer stores masking in _mask. This attributes also set for ISISReducer but in addition masking stored in attribute named mask.

When getting time to look at this - discuss with Mathieu. Also the init of SANSReducer may benifit from being split up into part deals with SANS in general and part which deals with SNS/HFIR only.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

http://www.mantidproject.org/Release_Notes_2_2_Full_List

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:9 Changed 7 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Gesner Passos
  • Description modified (diff)

comment:10 Changed 7 years ago by Gesner Passos

  • Component changed from Framework to SANS

comment:11 Changed 7 years ago by Gesner Passos

Invalid, what is important now is expressed in #8812

comment:12 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:13 Changed 7 years ago by Gesner Passos

  • Status changed from assigned to verify
  • Resolution set to invalid

comment:14 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:15 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

comment:16 Changed 7 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.2

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4910

Note: See TracTickets for help on using tickets.