Ticket #4073 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

TableWorkspace from find peak alg does not save/load correctly

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Loading and saving TableWorkspaces in general works when e.g. load/saving parameter fit results or fit covariance results, but as demonstrated not for TableWorkspaces generated using the Fit 'Find Peak' algorithm as demonstrated below:

1) load say mantid/Test/AutoTestData/argus0026287.nxs 2) plot 1st spectrum 3) In Fit Function window click on Setup button and select 'Find Peaks' 4) This should create a TableWorkspace named argus0026287_PeakList_tmp 5) Optionally delete argus0026287 workspace leaving just the TableWorkspace argus0026287_PeakList_tmp 5) From MantidPlot File menu select Save Project As 6) close MantidPlot 7) reopen MantidPlot and load in saved project file using File->Load->Project

When I run this, before saving argus0026287_PeakList_tmp contains:

0 14.8142 0.0695639 1.0471 -7.5717 0.531546 0 0 0 0 0 -6.15055 0.40134 0 0 0 0 0 -4.19504 0.225437 0

After reloading it - it contains no data.

So something goes wrong either in the saving or loading stage.

The code which saves TableWorkspaces is located in Nexus, see NexusFileIO::writeNexusTableWorkspace and code which load TableWorkspace is located at in DataHandling, see LoadNexusProcessed::loadTableEntry

Change History

comment:1 Changed 9 years ago by Karl Palmen

Project (as refered to in 'Save Project As') is missing from the Mantid concepts in the wiki.

comment:2 Changed 9 years ago by Karl Palmen

I've found out that the saved project file can be opened and read with Notepad (like a txt file). I see that the data from the find peaks appear to be present, so suggesting that the fault is with the load project rather than save project.

comment:3 Changed 9 years ago by Karl Palmen

Further investingation shows that the find peaks data found in the Project file is from the table created when looking at the data from find peaks. This table loads correctly when the project is reloaded. What is lost is the capability of the find peaks workspace to generate this table.

comment:4 Changed 9 years ago by Karl Palmen

  • Status changed from new to accepted

comment:5 Changed 9 years ago by Karl Palmen

Merge branch 'master' of github.com:mantidproject/mantid

Conflicts:

Code/Mantid/scripts/Inelastic/DirectEnergyConversion.py

For re #4073

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 4f0009e3f978e18a658ef77c7877e9421fccbcd6

comment:6 Changed 9 years ago by Karl Palmen

Added support of integer columns to Nexus table workspaces

This is needed to enable peak data to be saved in a MantidPlot project as required in ticket re #4073

Integer data is stored using the NX_INT32 info type.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f9f82d05fdbee990d7a4cec7a66289fe15627057

comment:7 Changed 9 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 9 years ago by Karl Palmen

Merge branch 'master' of github.com:mantidproject/mantid

Conflicts:

Code/Mantid/scripts/Inelastic/DirectEnergyConversion.py

For re #4073

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 4f0009e3f978e18a658ef77c7877e9421fccbcd6

comment:9 Changed 9 years ago by Karl Palmen

Added support of integer columns to Nexus table workspaces

This is needed to enable peak data to be saved in a MantidPlot project as required in ticket re #4073

Integer data is stored using the NX_INT32 info type.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f9f82d05fdbee990d7a4cec7a66289fe15627057

comment:10 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:11 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

saved/loaded mantidplot projects with multiple fit peak workspaces and recovered exactly the same as saved when loading project back in

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4920

Note: See TracTickets for help on using tickets.